Refactor: Use provider config map for API key checks and error messages

Author: bhouston

packages/agent/src/utils/errors.ts

@@ -1,47 +1,54 @@
-export const getAnthropicApiKeyError = () => `
-Error: ANTHROPIC_API_KEY environment variable is not set
-
-Before using MyCoder with Anthropic models, you must have an ANTHROPIC_API_KEY specified either:
-
-- As an environment variable, "export ANTHROPIC_API_KEY=[your-api-key]" or
-- In a .env file in the folder you run "mycoder" from
-
-Get an API key from https://www.anthropic.com/api
-For setup instructions, visit: https://mycoder.ai/docs/getting-started/anthropic
-`;
-
-export const getOpenAIApiKeyError = () => `
-Error: OPENAI_API_KEY environment variable is not set
-
-Before using MyCoder with OpenAI models, you must have an OPENAI_API_KEY specified either:
-
-- As an environment variable, "export OPENAI_API_KEY=[your-api-key]" or
+// Provider configuration map
+export const providerConfig: Record<
+  string,
+  { keyName: string; docsUrl: string } | undefined
+> = {
+  anthropic: {
+    keyName: 'ANTHROPIC_API_KEY',
+    docsUrl: 'https://mycoder.ai/docs/getting-started/anthropic',
+  },
+  openai: {
+    keyName: 'OPENAI_API_KEY',
+    docsUrl: 'https://mycoder.ai/docs/getting-started/openai',
+  },
+  xai: {
+    keyName: 'XAI_API_KEY',
+    docsUrl: 'https://mycoder.ai/docs/getting-started/xai',
+  },
+  mistral: {
+    keyName: 'MISTRAL_API_KEY',
+    docsUrl: 'https://mycoder.ai/docs/getting-started/mistral',
+  },
+  // No API key needed for ollama as it uses a local server
+  ollama: undefined,
+};
+
+/**
+ * Generates a provider-specific API key error message
+ * @param provider The LLM provider name
+ * @returns Error message with provider-specific instructions
+ */
+export const getProviderApiKeyError = (provider: string): string => {
+  const config = providerConfig[provider];
+
+  if (!config) {
+    return `Unknown provider: ${provider}`;
+  }
+
+  const { keyName, docsUrl } = config;
+
+  return `
+Error: ${keyName} environment variable is not set
+
+Before using MyCoder with ${provider} models, you must have a ${keyName} specified either:
+
+- As an environment variable, "export ${keyName}=[your-api-key]" or
 - In a .env file in the folder you run "mycoder" from
 
-Get an API key from https://platform.openai.com/api-keys
-For setup instructions, visit: https://mycoder.ai/docs/getting-started/openai
+For setup instructions, visit: ${docsUrl}
 `;
+};
 
-export const getXAIApiKeyError = () => `
-Error: XAI_API_KEY environment variable is not set
-
-Before using MyCoder with xAI models, you must have an XAI_API_KEY specified either:
-
-- As an environment variable, "export XAI_API_KEY=[your-api-key]" or
-- In a .env file in the folder you run "mycoder" from
-
-Get an API key from https://platform.xai.com
-For setup instructions, visit: https://mycoder.ai/docs/getting-started/xai
-`;
-
-export const getMistralApiKeyError = () => `
-Error: MISTRAL_API_KEY environment variable is not set
-
-Before using MyCoder with Mistral models, you must have a MISTRAL_API_KEY specified either:
-
-- As an environment variable, "export MISTRAL_API_KEY=[your-api-key]" or
-- In a .env file in the folder you run "mycoder" from
-
-Get an API key from https://console.mistral.ai/api-keys/
-For setup instructions, visit: https://mycoder.ai/docs/getting-started/mistral
-`;
+// Legacy function for backward compatibility
+export const getAnthropicApiKeyError = () =>
+  getProviderApiKeyError('anthropic');

packages/cli/src/commands/$default.ts

@@ -6,10 +6,8 @@ import {
   toolAgent,
   Logger,
   getTools,
-  getAnthropicApiKeyError,
-  getOpenAIApiKeyError,
-  getXAIApiKeyError,
-  getMistralApiKeyError,
+  getProviderApiKeyError,
+  providerConfig,
   userPrompt,
   LogLevel,
   subAgentTool,
@@ -98,24 +96,17 @@ export const command: CommandModule<SharedOptions, DefaultArgs> = {
       const userModelName = argv.modelName || userConfig.modelName;
 
       // Early API key check based on model provider
-      if (userModelProvider === 'anthropic' && !process.env.ANTHROPIC_API_KEY) {
-        logger.error(getAnthropicApiKeyError());
-        throw new Error('Anthropic API key not found');
-      } else if (
-        userModelProvider === 'openai' &&
-        !process.env.OPENAI_API_KEY
-      ) {
-        logger.error(getOpenAIApiKeyError());
-        throw new Error('OpenAI API key not found');
-      } else if (userModelProvider === 'xai' && !process.env.XAI_API_KEY) {
-        logger.error(getXAIApiKeyError());
-        throw new Error('xAI API key not found');
-      } else if (
-        userModelProvider === 'mistral' &&
-        !process.env.MISTRAL_API_KEY
-      ) {
-        logger.error(getMistralApiKeyError());
-        throw new Error('Mistral API key not found');
+      const providerSettings =
+        providerConfig[userModelProvider as keyof typeof providerConfig];
+
+      if (providerSettings) {
+        const { keyName } = providerSettings;
+        const apiKey = process.env[keyName];
+
+        if (!apiKey) {
+          logger.error(getProviderApiKeyError(userModelProvider));
+          throw new Error(`${userModelProvider} API key not found`);
+        }
       }
       // No API key check needed for Ollama as it uses a local server