Edge browser sends KeyEvent asynchronously

Edge:handleAcceleratorKeyPressed must handle Browser:sendKeyEvent
asynchronously as KeyEvent's Listeners can cause deadlock. Hence, the
Handled of this event is set if there exists a listener for the event or
a Display filter.

Author: amartya4256

bundles/org.eclipse.swt/Eclipse SWT Browser/win32/org/eclipse/swt/browser/Edge.java

@@ -1573,9 +1573,12 @@ int handleAcceleratorKeyPressed(long pView, long pArgs) {
 			return COM.S_OK;
 		}
 
-		if (!sendKeyEvent(keyEvent)) {
-			args.put_Handled(true);
-		}
+		asyncExec(() -> {
+			sendKeyEvent(keyEvent);
+		});
+
+		boolean hasListener = browser.getListeners(keyEvent.type).length != 0 || browser.getDisplay().filters(keyEvent.type);
+		args.put_Handled(hasListener);
 	} else {
 		keyEvent.type = SWT.KeyUp;
 		browser.notifyListeners (keyEvent.type, keyEvent);

bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java

@@ -1224,7 +1224,33 @@ boolean filterEvent (Event event) {
 	return false;
 }
 
-boolean filters (int eventType) {
+/**
+ * Checks for if there exists a listener in the collection of listeners who will
+ * be notified when an event of the given type occurs anywhere in a widget. The event type is one of the event constants
+ * defined in class <code>SWT</code>. When the event does occur,
+ * the listener is notified by sending it the <code>handleEvent()</code>
+ * message.
+ *
+ * <p>
+ * Filters are listeners which are registered at display level by calling {@link Display#addFilter(int, Listener)}. These listeners are triggered when there happens an event of the type they are registered with, anywhere in an SWT application.
+ * </p>
+ *
+ * <p>
+ * Needs to be public as the consumers of display can register a filter from any package using public method <code>addFilter</code> and might need to check if there exists a filter for an event.
+ * </p>
+ *
+ * @param eventType the type of an event to check if there exists a listener registered using <code>addFilter</code>
+ * @return true if there exists a listener which reacts to the eventType otherwise false
+ *
+ * @see Listener
+ * @see SWT
+ * @see #addFilter
+ * @see #removeFilter
+ * @see #removeListener
+ *
+ * @since 3.133
+ */
+public boolean filters (int eventType) {
 	if (filterTable == null) return false;
 	return filterTable.hooks (eventType);
 }

bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Widget.java

@@ -870,7 +870,7 @@ NSRect expansionFrameWithFrame_inView(long id, long sel, NSRect cellRect, long v
 	return result;
 }
 
-public boolean filters (int eventType) {
+boolean filters (int eventType) {
 	return display.filters (eventType);
 }
 

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Display.java

@@ -1987,7 +1987,33 @@ boolean filterEvent (Event event) {
 	return false;
 }
 
-boolean filters (int eventType) {
+/**
+ * Checks for if there exists a listener in the collection of listeners who will
+ * be notified when an event of the given type occurs anywhere in a widget. The event type is one of the event constants
+ * defined in class <code>SWT</code>. When the event does occur,
+ * the listener is notified by sending it the <code>handleEvent()</code>
+ * message.
+ *
+ * <p>
+ * Filters are listeners which are registered at display level by calling {@link Display#addFilter(int, Listener)}. These listeners are triggered when there happens an event of the type they are registered with, anywhere in an SWT application.
+ * </p>
+ *
+ * <p>
+ * Needs to be public as the consumers of display can register a filter from any package using public method <code>addFilter</code> and might need to check if there exists a filter for an event.
+ * </p>
+ *
+ * @param eventType the type of an event to check if there exists a listener registered using <code>addFilter</code>
+ * @return true if there exists a listener which reacts to the eventType otherwise false
+ *
+ * @see Listener
+ * @see SWT
+ * @see #addFilter
+ * @see #removeFilter
+ * @see #removeListener
+ *
+ * @since 3.133
+ */
+public boolean filters (int eventType) {
 	if (filterTable == null) return false;
 	return filterTable.hooks (eventType);
 }

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Widget.java

@@ -1194,7 +1194,7 @@ long filterProc(long xEvent, long gdkEvent, long data2) {
 	return 0;
 }
 
-public boolean filters (int eventType) {
+boolean filters (int eventType) {
 	return display.filters (eventType);
 }
 

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Display.java

@@ -1347,7 +1347,35 @@ boolean filterEvent (Event event) {
 	return false;
 }
 
-boolean filters (int eventType) {
+
+
+/**
+ * Checks for if there exists a listener in the collection of listeners who will
+ * be notified when an event of the given type occurs anywhere in a widget. The event type is one of the event constants
+ * defined in class <code>SWT</code>. When the event does occur,
+ * the listener is notified by sending it the <code>handleEvent()</code>
+ * message.
+ *
+ * <p>
+ * Filters are listeners which are registered at display level by calling {@link Display#addFilter(int, Listener)}. These listeners are triggered when there happens an event of the type they are registered with, anywhere in an SWT application.
+ * </p>
+ *
+ * <p>
+ * Needs to be public as the consumers of display can register a filter from any package using public method <code>addFilter</code> and might need to check if there exists a filter for an event.
+ * </p>
+ *
+ * @param eventType the type of an event to check if there exists a listener registered using <code>addFilter</code>
+ * @return true if there exists a listener which reacts to the eventType otherwise false
+ *
+ * @see Listener
+ * @see SWT
+ * @see #addFilter
+ * @see #removeFilter
+ * @see #removeListener
+ *
+ * @since 3.133
+ */
+public boolean filters (int eventType) {
 	if (filterTable == null) return false;
 	return filterTable.hooks (eventType);
 }

bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Widget.java

@@ -510,7 +510,7 @@ void error (int code) {
 	SWT.error(code);
 }
 
-public boolean filters (int eventType) {
+boolean filters (int eventType) {
 	return display.filters (eventType);
 }