Skip to content

Commit 26ddd0d

Browse files
vogellaptziegler
authored andcommitted
Remove redundant isCanceled checks in SaveablesList and SaveableHelper
This addresses the proposal by ptziegler in PR #3542 to split the removal of isCanceled checks.
1 parent e15e9bf commit 26ddd0d

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveableHelper.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,6 @@ private static boolean saveModels(ISaveablesSource modelSource, final IWorkbench
193193
continue;
194194
}
195195
doSaveModel(model, subMonitor.split(1), window, confirm);
196-
if (subMonitor.isCanceled()) {
197-
break;
198-
}
199196
}
200197
} finally {
201198
monitorWrap.done();

bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveablesList.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -796,9 +796,6 @@ public boolean saveModels(final List<Saveable> finalModels, final IShellProvider
796796
continue;
797797
}
798798
SaveableHelper.doSaveModel(model, subMonitor.split(1), shellProvider, blockUntilSaved);
799-
if (subMonitor.isCanceled()) {
800-
break;
801-
}
802799
}
803800
monitorWrap.done();
804801
};

0 commit comments

Comments
 (0)