From 5ae934b2175ffbc6593f55fcafd7dab6224f7f3b Mon Sep 17 00:00:00 2001 From: Deepika Udayagiri Date: Tue, 16 Dec 2025 18:55:45 +0530 Subject: [PATCH] This pr marks several unused deprecated methods/constants for removal. --- .../src/org/eclipse/jface/dialogs/DialogPage.java | 2 +- .../src/org/eclipse/jface/dialogs/InputDialog.java | 2 +- .../org/eclipse/jface/fieldassist/FieldAssistColors.java | 6 +++--- .../org/eclipse/jface/fieldassist/TextControlCreator.java | 2 +- .../src/org/eclipse/jface/preference/FieldEditor.java | 4 ++-- .../src/org/eclipse/jface/resource/ColorDescriptor.java | 2 +- .../eclipse/jface/resource/CompositeImageDescriptor.java | 2 +- .../src/org/eclipse/jface/resource/FontDescriptor.java | 2 +- .../src/org/eclipse/jface/resource/ImageDescriptor.java | 2 +- .../src/org/eclipse/jface/resource/ResourceManager.java | 2 +- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogPage.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogPage.java index 8b750c45b34..649a8f7d19a 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogPage.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogPage.java @@ -307,7 +307,7 @@ public String getTitle() { * @return the tool tip text, or null if none * @deprecated */ - @Deprecated + @Deprecated(forRemoval = true, since = "2026-03") protected final String getToolTipText(int widgetId) { // return nothing by default return null; diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/InputDialog.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/InputDialog.java index 572afa7706d..9ff98f69415 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/InputDialog.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/InputDialog.java @@ -171,7 +171,7 @@ protected Control createDialogArea(Composite parent) { * @return the error message label * @deprecated use setErrorMessage(String) instead */ - @Deprecated + @Deprecated(forRemoval = true, since = "2026-03") protected Label getErrorMessageLabel() { return null; } diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/FieldAssistColors.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/FieldAssistColors.java index 64d71454d4b..cf5dc9d3a04 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/FieldAssistColors.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/FieldAssistColors.java @@ -43,7 +43,7 @@ * @since 3.2 * @deprecated As of 3.3, this class is no longer necessary. */ -@Deprecated +@Deprecated(forRemoval = true, since = "2026-03") public class FieldAssistColors { private static boolean DEBUG = false; @@ -77,7 +77,7 @@ public class FieldAssistColors { * @return the RGB value indicating a background color appropriate for * indicating an error in the control. */ - @Deprecated + @Deprecated(forRemoval = true, since = "2026-03") public static RGB computeErrorFieldBackgroundRGB(Control control) { /* * Use a 10% alpha of the error color applied on top of the widget @@ -110,7 +110,7 @@ public static RGB computeErrorFieldBackgroundRGB(Control control) { * the control on which the background color will be used. * @return the color used to indicate that a field is required. */ - @Deprecated + @Deprecated(forRemoval = true, since = "2026-03") public static Color getRequiredFieldBackgroundColor(Control control) { final Display display = control.getDisplay(); diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/TextControlCreator.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/TextControlCreator.java index 208e5b2fa29..1942ce234a7 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/TextControlCreator.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/TextControlCreator.java @@ -25,7 +25,7 @@ * @deprecated As of 3.3, clients should use {@link ControlDecoration} instead * of {@link DecoratedField}. */ -@Deprecated +@Deprecated(forRemoval = true, since = "2026-03") public class TextControlCreator implements IControlCreator { @Deprecated diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/FieldEditor.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/FieldEditor.java index 2b910819294..1deb91878e7 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/FieldEditor.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/FieldEditor.java @@ -426,7 +426,7 @@ public String getPreferenceName() { * @return the preference page, or null if none * @deprecated use #getPage() */ - @Deprecated + @Deprecated(forRemoval = true, since = "2026-03") protected PreferencePage getPreferencePage() { if(page != null && page instanceof PreferencePage) { return (PreferencePage) page; @@ -591,7 +591,7 @@ public void setPreferenceName(String name) { * @param preferencePage the preference page, or null if none * @deprecated use #setPage(DialogPage) */ - @Deprecated + @Deprecated(forRemoval = true, since = "2026-03") public void setPreferencePage(PreferencePage preferencePage) { setPage(preferencePage); } diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ColorDescriptor.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ColorDescriptor.java index c43018ad6c1..4d2acf1885f 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ColorDescriptor.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ColorDescriptor.java @@ -41,7 +41,7 @@ public abstract class ColorDescriptor extends DeviceResourceDescriptor { * original Color's constructor. * @return a newly created ColorDescriptor that describes the given Color. */ - @Deprecated + @Deprecated(forRemoval = true, since = "2026-03") public static ColorDescriptor createFrom(Color toCreate, Device originalDevice) { return new RGBColorDescriptor(toCreate); } diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/CompositeImageDescriptor.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/CompositeImageDescriptor.java index ba003abed28..3221dc3b9ab 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/CompositeImageDescriptor.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/CompositeImageDescriptor.java @@ -434,7 +434,7 @@ protected int getTransparentPixel() { * @deprecated This method doesn't make sense and should never have been * made API. */ - @Deprecated + @Deprecated(forRemoval = true, since = "2026-03") protected void setImageData(ImageData imageData) { this.imageData = imageData; } diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/FontDescriptor.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/FontDescriptor.java index 135b9a6678f..6e348d0ef1c 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/FontDescriptor.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/FontDescriptor.java @@ -42,7 +42,7 @@ public abstract class FontDescriptor extends DeviceResourceDescriptor { * the font's constructor when it was first created. * @return a newly created FontDescriptor. */ - @Deprecated + @Deprecated(forRemoval = true, since = "2026-03") public static FontDescriptor createFrom(Font font, Device originalDevice) { return new ArrayFontDescriptor(font); } diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ImageDescriptor.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ImageDescriptor.java index 23eae314c9a..5c658690766 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ImageDescriptor.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ImageDescriptor.java @@ -183,7 +183,7 @@ public static ImageDescriptor createWithFlags(ImageDescriptor originalImage, int * @param theDevice the device that was used to create the Image * @return a newly created image descriptor */ - @Deprecated + @Deprecated(forRemoval = true, since = "2026-03") public static ImageDescriptor createFromImage(Image img, Device theDevice) { return new ImageDataImageDescriptor(img); } diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ResourceManager.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ResourceManager.java index 816a198c61a..a149b67d13e 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ResourceManager.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ResourceManager.java @@ -305,7 +305,7 @@ public final Font createFont(FontDescriptor descriptor) { * @param descriptor description of the font to destroy * @deprecated use {@link #destroy(DeviceResourceDescriptor)} instead */ - @Deprecated(since = "3.31") + @Deprecated(forRemoval = true, since = "2026-03") public final void destroyFont(FontDescriptor descriptor) { destroy(descriptor); }