JDT Clean-up Use String.replace() instead of String.replaceAll() when

possible

In eclipse-platform/eclipse.platform.ui#3517
we discuss which automatic clean-ups we should add. This is the result
of a manual run in eclipse-platform to see if this clean-up has
issues. Also by running it manually before enabling the clean-ups we
avoid creating PR per bundle.

Author: vogella

ant/org.eclipse.ant.ui/Ant Tools Support/org/eclipse/ant/internal/ui/views/actions/SearchForBuildFilesDialog.java

@@ -387,11 +387,11 @@ class ResourceProxyVisitor implements IResourceProxyVisitor {
 			// The character "." must be escaped in regex
 			String input = getInput();
 			// replace "." with "\\."
-			input = input.replaceAll("\\.", "\\\\."); //$NON-NLS-1$ //$NON-NLS-2$
+			input = input.replace(".", "\\."); //$NON-NLS-1$ //$NON-NLS-2$
 			// replace "*" with ".*"
-			input = input.replaceAll("\\*", "\\.\\*"); //$NON-NLS-1$ //$NON-NLS-2$
+			input = input.replace("*", ".*"); //$NON-NLS-1$ //$NON-NLS-2$
 			// replace "?" with ".?"
-			input = input.replaceAll("\\?", "\\.\\?"); //$NON-NLS-1$ //$NON-NLS-2$
+			input = input.replace("?", ".?"); //$NON-NLS-1$ //$NON-NLS-2$
 			pattern = Pattern.compile(input);
 		}
 

debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/ResourceExtender.java

@@ -74,8 +74,8 @@ public boolean test(Object receiver, String method, Object[] args, Object expect
 			if (PROPERTY_MATCHES_PATTERN.equals(method)) {
 				String fileName = resource.getName();
 				String expected = (String) expectedValue;
-				expected = expected.replaceAll("\\.", "\\\\.");  //$NON-NLS-1$//$NON-NLS-2$
-				expected = expected.replaceAll("\\*", "\\.\\*");  //$NON-NLS-1$//$NON-NLS-2$
+				expected = expected.replace(".", "\\.");  //$NON-NLS-1$//$NON-NLS-2$
+				expected = expected.replace("*", ".*");  //$NON-NLS-1$//$NON-NLS-2$
 				Pattern pattern = Pattern.compile(expected);
 				boolean retVal = pattern.matcher(fileName).find();
 				return retVal;

debug/org.eclipse.ui.externaltools/External Tools Base/org/eclipse/ui/externaltools/internal/variables/BuildFilesResolver.java

@@ -123,7 +123,7 @@ public String resolveValue(IDynamicVariable variable, String argument) throws Co
 						// the filename so they don't conflict with these
 						// special quotes.
 						//
-						osPath = osPath.replaceAll("\"", "\\\\\""); //$NON-NLS-1$ //$NON-NLS-2$
+						osPath = osPath.replace("\"", "\\\""); //$NON-NLS-1$ //$NON-NLS-2$
 						fileList.append("\"" + osPath + "\""); //$NON-NLS-1$ //$NON-NLS-2$
 					}
 				}

resources/tests/org.eclipse.core.tests.resources/src/org/eclipse/core/tests/filesystem/FileStoreTest.java

@@ -756,7 +756,7 @@ public void testSortOrderPaths() {
 		List<String> pathsTrimmed = paths.stream().map(s -> s //
 				.replaceAll("/$", "") // remove trailing slashes
 				.replaceAll("/[^/]+/\\.\\./", "/") // collapse /a/../ to /
-				.replaceAll("/\\./", "/") // collapse /./ to /
+				.replace("/./", "/") // collapse /./ to /
 		).toList();
 		paths = new ArrayList<>(paths); // to get a mutable copy for shuffling
 		Collections.shuffle(paths);

team/bundles/org.eclipse.team.core/src/org/eclipse/team/core/ScmUrlImportDescription.java

@@ -59,7 +59,7 @@ public String getUrl() {
 	}
 
 	public URI getUri() {
-		return URI.create(url.replaceAll("\"", "")); //$NON-NLS-1$//$NON-NLS-2$
+		return URI.create(url.replace("\"", "")); //$NON-NLS-1$//$NON-NLS-2$
 	}
 
 	public void setUrl(String url) {

team/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/dialogs/PreferencePageContainerDialog.java

@@ -387,7 +387,7 @@ public void updateMessage() {
 				} else {
 					//remove mnemonic see bug 75886
 					String title = currentPage.getTitle();
-					title = title.replaceAll("&", "");//$NON-NLS-1$ //$NON-NLS-2$
+					title = title.replace("&", "");//$NON-NLS-1$ //$NON-NLS-2$
 					setMessage(title);
 				}
 			} else {

terminal/bundles/org.eclipse.terminal.view.ui/src/org/eclipse/terminal/view/ui/internal/tabs/TabFolderManager.java

@@ -888,7 +888,7 @@ protected String state2msg(CTabItem item, TerminalState state) {
 		// Get he current terminal state as string
 		String stateStr = state.toString();
 		// Lookup a matching text representation of the state
-		String key = "TabFolderManager_state_" + stateStr.replaceAll("\\.", " ").trim().toLowerCase(); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
+		String key = "TabFolderManager_state_" + stateStr.replace('.', ' ').trim().toLowerCase(); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
 		String stateMsg = null;
 		if (properties != null) {
 			stateMsg = properties.get(key) instanceof String ? (String) properties.get(key) : null;

ua/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/ContextHelpDialog.java

@@ -227,8 +227,8 @@ private Control createInfoArea(Composite parent) {
 		}
 		if (styledText == null && context.getText() != null) {
 			styledText = context.getText();
-			styledText= styledText.replaceAll("<b>","<@#\\$b>"); //$NON-NLS-1$ //$NON-NLS-2$
-			styledText= styledText.replaceAll("</b>", "</@#\\$b>"); //$NON-NLS-1$ //$NON-NLS-2$
+			styledText= styledText.replace("<b>","<@#$b>"); //$NON-NLS-1$ //$NON-NLS-2$
+			styledText= styledText.replace("</b>", "</@#$b>"); //$NON-NLS-1$ //$NON-NLS-2$
 		}
 		if (styledText == null) { // no description found in context objects.
 			styledText = Messages.ContextHelpPart_noDescription;

ua/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/browser/embedded/EmbeddedBrowser.java

@@ -326,7 +326,7 @@ private void initializeStatusBar(Browser browser) {
 
 		// Text
 		browser.addStatusTextListener(event -> {
-			event.text = event.text.replaceAll("&", "&&"); //$NON-NLS-1$ //$NON-NLS-2$
+			event.text = event.text.replace("&", "&&"); //$NON-NLS-1$ //$NON-NLS-2$
 			if (!event.text.equals(statusText)) {
 				statusText = event.text;
 				statusBarText.setText(statusText);

ua/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/util/EscapeUtils.java

@@ -43,7 +43,7 @@ public static String escapeSpecialCharsLeavinggBold(String value) {
 	}
 
 	public static String escapeAmpersand(String value) {
-		return value.replaceAll("&", "&"); //$NON-NLS-1$ //$NON-NLS-2$
+		return value.replace("&", "&"); //$NON-NLS-1$ //$NON-NLS-2$
 	}
 
 	/**