Skip to content

Commit 9d8b992

Browse files
wahlbrinkakurtakov
authored andcommitted
Fix not disposed Clipboard instances
1 parent 1183474 commit 9d8b992

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

team/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/ClipboardCompare.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,11 @@ protected Object prepareInput(IProgressMonitor monitor)
188188
*/
189189
private Object getClipboard() {
190190
Clipboard clip = new Clipboard(Display.getDefault());
191-
return clip.getContents(TextTransfer.getInstance());
191+
try {
192+
return clip.getContents(TextTransfer.getInstance());
193+
} finally {
194+
clip.dispose();
195+
}
192196
}
193197

194198
@Override

team/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/ClipboardReplace.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,11 @@ protected boolean isEnabled(ISelection selection) {
9292
*/
9393
private Object getClipboard() {
9494
Clipboard clip = new Clipboard(Display.getDefault());
95-
return clip.getContents(TextTransfer.getInstance());
95+
try {
96+
return clip.getContents(TextTransfer.getInstance());
97+
} finally {
98+
clip.dispose();
99+
}
96100
}
97101

98102
}

0 commit comments

Comments
 (0)