From 03de489a06fedb384a715b74d65359bec7dee907 Mon Sep 17 00:00:00 2001 From: Heiko Klare Date: Fri, 25 Apr 2025 09:44:17 +0200 Subject: [PATCH] Remove hover images and replace faulty icon in org.eclipse.ui.console The hover images only replicate the ordinary icons without giving any benefit but just duplicate resources. One of the just added SVGs icons (for wordwrap) is even incorrect. This change completely removes the hover images in org.eclipse.ui.console, including their code usages and the just provisioned SVGs. --- .../icons/full/clcl16/lock_co.svg | 663 ------------------ .../icons/full/clcl16/pin.svg | 329 --------- .../icons/full/clcl16/wordwrap.svg | 427 ----------- .../internal/console/ConsolePluginImages.java | 3 - .../console/IInternalConsoleConstants.java | 5 - .../ui/internal/console/PinConsoleAction.java | 1 - .../ui/internal/console/ScrollLockAction.java | 1 - .../ui/internal/console/WordWrapAction.java | 1 - 8 files changed, 1430 deletions(-) delete mode 100644 debug/org.eclipse.ui.console/icons/full/clcl16/lock_co.svg delete mode 100644 debug/org.eclipse.ui.console/icons/full/clcl16/pin.svg delete mode 100644 debug/org.eclipse.ui.console/icons/full/clcl16/wordwrap.svg diff --git a/debug/org.eclipse.ui.console/icons/full/clcl16/lock_co.svg b/debug/org.eclipse.ui.console/icons/full/clcl16/lock_co.svg deleted file mode 100644 index c344c2e266f..00000000000 --- a/debug/org.eclipse.ui.console/icons/full/clcl16/lock_co.svg +++ /dev/null @@ -1,663 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/debug/org.eclipse.ui.console/icons/full/clcl16/pin.svg b/debug/org.eclipse.ui.console/icons/full/clcl16/pin.svg deleted file mode 100644 index 1b1325cdd01..00000000000 --- a/debug/org.eclipse.ui.console/icons/full/clcl16/pin.svg +++ /dev/null @@ -1,329 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/debug/org.eclipse.ui.console/icons/full/clcl16/wordwrap.svg b/debug/org.eclipse.ui.console/icons/full/clcl16/wordwrap.svg deleted file mode 100644 index d064ae2226d..00000000000 --- a/debug/org.eclipse.ui.console/icons/full/clcl16/wordwrap.svg +++ /dev/null @@ -1,427 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - image/svg+xml - - - - - - - - - - - - - - - - - - - - - diff --git a/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsolePluginImages.java b/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsolePluginImages.java index ae73f60cd55..f392cbbf01f 100644 --- a/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsolePluginImages.java +++ b/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsolePluginImages.java @@ -55,9 +55,6 @@ private static void declareImages() { //local toolbars declareRegistryImage(IConsoleConstants.IMG_LCL_CLEAR, LOCALTOOL + "clear_co.svg"); //$NON-NLS-1$ - declareRegistryImage(IInternalConsoleConstants.IMG_LCL_PIN, LOCALTOOL + "pin.svg"); //$NON-NLS-1$ - declareRegistryImage(IInternalConsoleConstants.IMG_LCL_LOCK, LOCALTOOL + "lock_co.svg"); //$NON-NLS-1$ - declareRegistryImage(IInternalConsoleConstants.IMG_LCL_WRAP, LOCALTOOL + "wordwrap.svg"); //$NON-NLS-1$ // enabled local toolbars declareRegistryImage(IInternalConsoleConstants.IMG_ELCL_CLEAR, ELCL + "clear_co.svg"); //$NON-NLS-1$ diff --git a/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IInternalConsoleConstants.java b/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IInternalConsoleConstants.java index 6b6c77a904a..d235e7126ed 100644 --- a/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IInternalConsoleConstants.java +++ b/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IInternalConsoleConstants.java @@ -16,11 +16,6 @@ public interface IInternalConsoleConstants { - // tool images - String IMG_LCL_PIN = "IMG_LCL_PIN"; //$NON-NLS-1$ - String IMG_LCL_LOCK = "IMG_LCL_LOCK"; //$NON-NLS-1$ - String IMG_LCL_WRAP = "IMG_LCL_WRAP"; //$NON-NLS-1$ - // enabled local tool images String IMG_ELCL_PIN = "IMG_ELCL_PIN"; //$NON-NLS-1$ String IMG_ELCL_CLEAR= "IMG_ELCL_CLEAR"; //$NON-NLS-1$ diff --git a/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/PinConsoleAction.java b/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/PinConsoleAction.java index 123a7bb8749..59ebded483e 100644 --- a/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/PinConsoleAction.java +++ b/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/PinConsoleAction.java @@ -35,7 +35,6 @@ public PinConsoleAction(IConsoleView view) { super(ConsoleMessages.PinConsoleAction_0, IAction.AS_CHECK_BOX); setToolTipText(ConsoleMessages.PinConsoleAction_1); setImageDescriptor(ConsolePluginImages.getImageDescriptor(IInternalConsoleConstants.IMG_ELCL_PIN)); - setHoverImageDescriptor(ConsolePluginImages.getImageDescriptor(IInternalConsoleConstants.IMG_LCL_PIN)); PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IConsoleHelpContextIds.CONSOLE_PIN_CONSOLE_ACITON); fView = view; update(); diff --git a/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ScrollLockAction.java b/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ScrollLockAction.java index cb9847db151..cee50e222b9 100644 --- a/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ScrollLockAction.java +++ b/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ScrollLockAction.java @@ -31,7 +31,6 @@ public ScrollLockAction(IConsoleView consoleView) { fConsoleView = consoleView; setToolTipText(ConsoleMessages.ScrollLockAction_1); - setHoverImageDescriptor(ConsolePluginImages.getImageDescriptor(IInternalConsoleConstants.IMG_LCL_LOCK)); setImageDescriptor(ConsolePluginImages.getImageDescriptor(IInternalConsoleConstants.IMG_ELCL_LOCK)); PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IConsoleHelpContextIds.CONSOLE_SCROLL_LOCK_ACTION); boolean checked = fConsoleView.getScrollLock(); diff --git a/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/WordWrapAction.java b/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/WordWrapAction.java index 983ed401dbc..963c3891ce0 100644 --- a/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/WordWrapAction.java +++ b/debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/WordWrapAction.java @@ -39,7 +39,6 @@ public WordWrapAction(IConsoleView consoleView) { fConsoleView = consoleView; setToolTipText(ConsoleMessages.WordWrapAction_1); - setHoverImageDescriptor(ConsolePluginImages.getImageDescriptor(IInternalConsoleConstants.IMG_LCL_WRAP)); setImageDescriptor(ConsolePluginImages.getImageDescriptor(IInternalConsoleConstants.IMG_ELCL_WRAP)); PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IConsoleHelpContextIds.CONSOLE_WORD_WRAP_ACTION);