Utilize AcceptDocs interface for lazy evaluation of filters for *_flat vector indices #137042 #139145
+114
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
benwtrent
requested changes
Dec 5, 2025
Member
benwtrent
left a comment
benwtrent
left a comment
There was a problem hiding this comment.
no we should not do this. The whole point is not fully realizing the iterator into a set, but instead iterating the vector values along with the iterator, collecting them and bulk scoring them.
benwtrent
added
:Search Relevance/Vectors
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses AcceptDocs interface for evaluation of filters.
Tested by building then running a flat vector test and a broader vector test.
#137042