[9.1] allocation: time compute rounds by start time over last convergence (#137418) #139147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#137418) In the DesiredBalanceAllocator, there are periodic log messages that warn of long-running allocation balancing rounds. These track the number of loop iterations and the amount of time passed since the last convergence, and log when either exceeds a limit. A previous effort (4c979aa, elastic#100850) persisted these metrics across compute runs so that a sequence of cluster state changes did not disrupt these warnings. However, the modified time-based threshold compares the current time against the last convergence, instead of the first effort at recompute. If enough time has passed between balancing rounds, this produces a warn-level message that misrepresents the round's compute time. This change continues to include the time since last convergence, but uses the time since compute began as the log threshold and as the time since resumption. Fixes: ES-13327
schase-es
added
:Distributed Coordination/Allocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 9.1: