allocation: add timing and iteration to logging #139150
Open
+71
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DesiredBalanceComputer now has three groups of timing and iteration counts: the current round iteration and duration, the since-recompute iterations, round count, and duration, and the time since convergence. This logging change includes all available information in the logs, and groups them together by kind.
schase-es
added
>non-issue
:Distributed Coordination/Allocation
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
reviewed
Dec 5, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Thanks, much easier to review this separately. I left a couple of small suggestions for improvement that also apply to the same changes further down. Overall tho it looks good to add these extra details to these messages.
| """ | ||
| Desired balance computation for [%d] converged after [%s] and [%d] iterations, \ | ||
| resumed computation [%d] times with [%d] iterations since the last resumption [%s] ago""", | ||
| Desired balance computation for [%d] converged after [%s] and [%d] iterations this round, \ |
Contributor
There was a problem hiding this comment.
I think the total time & number of iterations is more important than the number since it was last interrupted - could we reverse the order so that the total numbers come first?
| () -> Strings.format( | ||
| "Desired balance computation for [%d] converged after [%s] and [%d] iterations", | ||
| """ | ||
| Desired balance computation for [%d] converged after [%s] and [%d] iterations this round, \ |
Contributor
There was a problem hiding this comment.
"this round" implies there have been other rounds, but that's not the case here. Maybe "in a single round" would be clearer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DesiredBalanceComputer now has three groups of timing and iteration counts: the current round iteration and duration, the since-recompute iterations, round count, and duration, and the time since convergence. This logging change includes all available information in the logs, and groups them together by kind.