ESQL - Tdigest data type #139151
Merged
ESQL - Tdigest data type #139151
+225
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-napoleon
added
>non-issue
:StorageEngine/ES|QL
…type' into tdigest-data-type
Conflicts: server/src/main/resources/transport/upper_bounds/9.3.csv
Conflicts: server/src/main/resources/transport/upper_bounds/9.3.csv x-pack/plugin/esql/qa/testFixtures/src/main/java/org/elasticsearch/xpack/esql/EsqlTestUtils.java x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/nulls/Coalesce.java
…type' into tdigest-data-type
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
dnhatn
approved these changes
Dec 8, 2025
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
One comment, but LGTM. Thanks Mark!
| this(encodeCentroidsAndCounts(centroids, counts), min, max, sum, valueCount); | ||
| } | ||
|
|
||
| public TDigestHolder(StreamInput in) throws IOException { |
Member
There was a problem hiding this comment.
We usually place readFrom and writeTo next to each other so they can be easily scanned and compared.
Conflicts: server/src/main/resources/transport/upper_bounds/9.3.csv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an ESQL data type for TDigest fields. I've attempted to keep this as minimal as possible, so there's a lot of stuff that we expect data types to support that doesn't work yet (
Case,Is Null, etc). That will come with future PRs.The biggest change here is making
TDigestHolderwritable, which is required for using it inLiteral. That in turn is required for the ESQL tests.