Tests - add mocking to test get_services()

This may be overkill but it does increase test coverage and if we develop more fine-grained tests for `_get()` in the future, mock will help.

Author: joncotton

embedly/tests.py

@@ -7,6 +7,11 @@
 except ImportError:  # pragma: no cover
     import unittest  # pragma: no cover
 
+try:  # pragma: no cover
+    from unittest import mock  # pragma: no cover
+except ImportError:  # Python < 3.3  # pragma: no cover
+    import mock  # pragma: no cover
+
 from embedly.client import Embedly
 from embedly.models import Url
 
@@ -182,13 +187,31 @@ def test_regex_url_matches(self):
         self.assertFalse(
             client.is_supported('http://yfrog.com/h22eu4j'))
 
+    @mock.patch.object(Embedly, 'get_services')
+    def test_regex_access_triggers_get_services(self, mock_services):
+        client = Embedly(self.key)
+        client.regex
+
+        self.assertTrue(mock_services.called)
+        self.assertIsNone(client._regex)
+
     def test_services_can_be_manually_configured(self):
         client = Embedly(self.key)
         client.services = ['nothing', 'like', 'real', 'response', 'data']
 
         self.assertTrue('nothing' in client.get_services())
         self.assertEqual(len(client.get_services()), 5)
 
+    @mock.patch('httplib2.Http', autospec=True)
+    def test_services_remains_empty_on_failed_http(self, MockHttp):
+        MockHttp.return_value.request.return_value = ({'status': 500}, "")
+
+        client = Embedly(self.key)
+        client.get_services()
+
+        self.assertFalse(client.services)
+        self.assertTrue(MockHttp.return_value.request.called)
+
     def test_get_services_retrieves_data_and_builds_regex(self):
         client = Embedly(self.key)
         client.get_services()

setup.py

@@ -9,6 +9,9 @@
 if sys.version_info[:2] < (2, 7):
     tests_require.append('unittest2')
 
+if sys.version_info[:2] < (3, 3):
+    tests_require.append('mock')
+
 
 def get_version():
     with open(os.path.join('embedly', '__init__.py')) as f:

tox.ini

@@ -5,4 +5,12 @@ envlist = py26,py27,py32,py33
 commands=python embedly/tests.py
 
 [testenv:py26]
-deps = unittest2
+deps =
+	mock
+	unittest2
+
+[testenv:py27]
+deps = mock
+
+[testenv:py32]
+deps = mock