Skip to content

Commit 74c2895

Browse files
committed
Use shared type tests for preview and stable types
This guarantees that we will be testing exactly what our consumers use, with the only difference being the specific import paths used to expose the side effect modules. It also keeps the type tests from diverging between the two sets of types. Previously, following the DefinitelyTyped approach, all the preview type modules had their own `tsconfig.json`, but this actually made them fail to interoperate with stable types, and this approach *only* works if they work together. Removing those means they operate as a single coherent set of type definitions with the stable types, distinguished *only* by the way they are authored.
1 parent ed4a6e9 commit 74c2895

File tree

111 files changed

+7
-293
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

111 files changed

+7
-293
lines changed

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,8 @@
5050
"test:blueprints": "yarn test:blueprints:js && yarn test:blueprints:ts",
5151
"test:node": "qunit tests/node/**/*-test.js",
5252
"test:browserstack": "node bin/run-browserstack-tests.js",
53-
"type-check:packages": "tsc --noEmit",
54-
"type-check:stable": "tsc --noEmit --project type-tests/stable",
55-
"type-check:preview": "tsc --noEmit --project type-tests/preview",
53+
"type-check:internals": "tsc --noEmit",
54+
"type-check:types": "tsc --noEmit --project type-tests",
5655
"type-check": "npm-run-all type-check:*"
5756
},
5857
"dependencies": {

type-tests/preview/@ember/application-test/application-instance.ts renamed to type-tests/@ember/application-test/application-instance.ts

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)