Add macro hygiene test (#10)

* hide the forbidden symbol before Alex Arslan sees it

* add macro hygeine test

Author: ericphanson

src/BenchmarkHistograms.jl

@@ -57,12 +57,13 @@ function Base.show(io::IO, ::MIME"text/plain", bp::BenchmarkHistogram; nbins=NBI
         println(io)
     end
     print(io, "min: ", minstr, "; mean: ", meanstr, "; median: ", medstr, "; max: ", maxstr, ".")
+    return nothing
 end
 
 macro benchmark(exprs...)
-    quote
+    return esc(quote
         $BenchmarkHistogram($BenchmarkTools.@benchmark($(exprs...)))
-    end |> esc
+    end)
 end
 
 # We vendor some pretty-printing methods from BenchmarkTools

test/runtests.jl

@@ -4,8 +4,8 @@ import BenchmarkTools
 
 
 function counting_tests(nbins=nothing)
-    bp = @benchmark 1+1
-    output = sprint(show, MIME"text/plain"(), bp)
+    bh = @benchmark 1+1
+    output = sprint(show, MIME"text/plain"(), bh)
 
     # Don't want to test the exact string since the stats will
     # fluctuate. So let's just test that it contains the right
@@ -30,9 +30,9 @@ end
 
 
 function empty_test()
-    bp = @benchmark 1+1
-    empty!(bp.trial.times)
-    output = sprint(show, MIME"text/plain"(), bp)
+    bh = @benchmark 1+1
+    empty!(bh.trial.times)
+    output = sprint(show, MIME"text/plain"(), bh)
 
     # Don't want to test the exact string since the stats will
     # fluctuate. So let's just test that it contains the right
@@ -63,7 +63,6 @@ function with_bins(f, nbins)
 end
 
 @testset "BenchmarkHistograms.jl" begin
-
     @testset "Exports" begin
         @test symdiff(names(BenchmarkTools), names(BenchmarkHistograms)) == [:BenchmarkHistograms]
     end
@@ -76,4 +75,10 @@ end
     end
 end
 
+# Macro hygiene test; done in global scope intentionally
+f(x) = x+1
+y=10
+bh = @benchmark f($y)
+@test bh isa BenchmarkHistograms.BenchmarkHistogram
+
 include("vendor.jl")