Update tests

Author: biow0lf

spec/errbit_github_plugin/issue_tracker_spec.rb

@@ -110,12 +110,12 @@
     end
     let(:fake_github_client) do
       double("Fake GitHub Client").tap do |github_client|
-        github_client.stub(:create_issue).and_return(fake_issue)
+        expect(github_client).to receive(:create_issue).and_return(fake_issue)
       end
     end
     let(:fake_issue) do
       double("Fake Issue").tap do |issue|
-        issue.stub(:html_url).and_return("http://github.com/user/repos/issues/878")
+        expect(issue).to receive(:html_url).and_return("http://github.com/user/repos/issues/878")
       end
     end
 
@@ -127,7 +127,7 @@
         }
       end
       it "return issue url" do
-        Octokit::Client.stub(:new).with(
+        expect(Octokit::Client).to receive(:new).with(
           login: user["github_login"], access_token: user["github_oauth_token"]
         ).and_return(fake_github_client)
         expect(subject).to eq fake_issue.html_url
@@ -137,7 +137,7 @@
     context "signed in with password" do
       let(:user) { {} }
       it "return issue url" do
-        Octokit::Client.stub(:new).with(
+        expect(Octokit::Client).to receive(:new).with(
           login: options["username"], password: options["password"]
         ).and_return(fake_github_client)
         expect(subject).to eq fake_issue.html_url
@@ -149,7 +149,7 @@
         {"github_login" => "alice", "github_oauth_token" => "invalid_token"}
       end
       it "raise AuthenticationError" do
-        Octokit::Client.stub(:new).with(
+        expect(Octokit::Client).to receive(:new).with(
           login: user["github_login"], access_token: user["github_oauth_token"]
         ).and_raise(Octokit::Unauthorized)
         expect { subject }.to raise_error