Skip to content

Commit 38ddb2e

Browse files
committed
refactoring public API. remove argument order from new for NdSpline
1 parent 55d4c9d commit 38ddb2e

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

src/umv.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,11 @@ impl<'a, T> NdSpline<'a, T>
6363
///
6464
/// - `NdSpline` struct should not be created directly by a user in most cases.
6565
///
66-
pub fn new(order: usize, breaks: ArrayView1<'a, T>, coeffs: Array2<T>) -> NdSpline<'a, T> {
66+
pub fn new(breaks: ArrayView1<'a, T>, coeffs: Array2<T>) -> NdSpline<'a, T> {
6767
let c_shape = coeffs.shape();
6868
let ndim = c_shape[0];
69-
let pieces = c_shape[1] / order;
69+
let pieces = breaks.len() - 1;
70+
let order = c_shape[1] / pieces;
7071

7172
NdSpline {
7273
ndim,

src/umv/make.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,10 @@ impl<'a, T, D> CubicSmoothingSpline<'a, T, D>
3636
if pcount == 2 {
3737
drop(dx);
3838
let yi = y.slice(s![.., 0]).insert_axis(Axis(1));
39-
40-
let order = 2;
4139
let coeffs = stack![Axis(1), dydx, yi];
4240

4341
self.smooth = Some(one);
44-
self.spline = Some(NdSpline::new(order, breaks, coeffs));
42+
self.spline = Some(NdSpline::new(breaks, coeffs));
4543

4644
return Ok(())
4745
}
@@ -152,10 +150,8 @@ impl<'a, T, D> CubicSmoothingSpline<'a, T, D>
152150
stack![Axis(0), p1, p2, p3, p4].t().to_owned()
153151
};
154152

155-
let order = 4;
156-
157153
self.smooth = Some(p);
158-
self.spline = Some(NdSpline::new(order, breaks, coeffs));
154+
self.spline = Some(NdSpline::new(breaks, coeffs));
159155

160156
Ok(())
161157
}

0 commit comments

Comments
 (0)