fixes, remove unneeded tests (solved by type strictness)

Author: ryanio

lib/service/ethereumservice.ts

@@ -12,8 +12,6 @@ const defaultOptions = {
  * @memberof module:service
  */
 export class EthereumService extends Service {
-  public config: Config
-
   public flow: FlowControl
   public chain: Chain
   public interval: number

test/blockchain/chain.spec.ts

@@ -1,15 +1,15 @@
 import tape from 'tape'
-import { Block, BlockHeader, BlockData, HeaderData } from '@ethereumjs/block'
+import { Block, BlockData, HeaderData } from '@ethereumjs/block'
 import { BN } from 'ethereumjs-util'
 import { Chain } from '../../lib/blockchain'
 import { defaultLogger } from '../../lib/logging'
+import { Config } from '../../lib/config'
 defaultLogger.silent = true
 
 // explicitly import util and buffer,
 // needed for karma-typescript bundling
 import * as util from 'util' //eslint-disable-line @typescript-eslint/no-unused-vars
 import { Buffer } from 'buffer' //eslint-disable-line @typescript-eslint/no-unused-vars
-import { Config } from '../../lib/config'
 
 tape('[Chain]', (t) => {
   t.test('should test blockchain DB is initialized', async (t) => {
@@ -80,26 +80,6 @@ tape('[Chain]', (t) => {
     t.end()
   })
 
-  t.test('should handle bad arguments to putBlocks()', async (t) => {
-    const chain = new Chain({ config: new Config() }) // eslint-disable-line no-new
-    await chain.open()
-    t.notOk(await chain.putBlocks((<unknown>undefined) as Block[]), 'add undefined block')
-    t.notOk(await chain.putBlocks((<unknown>null) as Block[]), 'add null block')
-    t.notOk(await chain.putBlocks([]), 'add empty block list')
-    await chain.close()
-    t.end()
-  })
-
-  t.test('should handle bad arguments to putHeaders()', async (t) => {
-    const chain = new Chain({ config: new Config() }) // eslint-disable-line no-new
-    await chain.open()
-    t.notOk(await chain.putHeaders((<unknown>undefined) as BlockHeader[]), 'add undefined header')
-    t.notOk(await chain.putHeaders((<unknown>null) as BlockHeader[]), 'add null header')
-    t.notOk(await chain.putHeaders([]), 'add empty header list')
-    await chain.close()
-    t.end()
-  })
-
   t.test('should add block to chain', async (t) => {
     const chain = new Chain({ config: new Config() }) // eslint-disable-line no-new
     await chain.open()

test/net/server/rlpxserver.ts

@@ -78,6 +78,7 @@ tape('[RlpxServer]', (t) => {
   t.test('should return rlpx server info', async (t) => {
     const mockId = '123'
     const server = new RlpxServer({
+      config: new Config({ transports: [] }),
       bootnodes: '10.0.0.1:1234,10.0.0.2:1234',
     })
     server.initDpt = td.func()