Skip to content
This repository was archived by the owner on Mar 6, 2023. It is now read-only.

Commit 513f08f

Browse files
committed
Sanitize any html stack traces
1 parent 209b03c commit 513f08f

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/components/simple-stack-trace/simple-stack-trace-directive.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
angular.module('exceptionless.simple-stack-trace', [
55
'exceptionless.simple-error'
66
])
7-
.directive('simpleStackTrace', ['simpleErrorService', function (simpleErrorService) {
7+
.directive('simpleStackTrace', ['$sanitize', 'simpleErrorService', function ($sanitize, simpleErrorService) {
88
function buildStackFrames(exceptions) {
99
var frames = '';
1010
for (var index = 0; index < exceptions.length; index++) {
11-
frames += '<div class="stack-frame">' + exceptions[index].stack_trace.replace(' ', '');
11+
frames += '<div class="stack-frame">' + $sanitize(exceptions[index].stack_trace.replace(' ', ''));
1212

1313
if (index < (exceptions.length - 1)) {
1414
frames += '<div>--- End of inner exception stack trace ---</div>';
@@ -33,9 +33,9 @@
3333
header += ' ---> ';
3434
}
3535

36-
header += '<span class="ex-type">' + exceptions[index].type + '</span>';
36+
header += '<span class="ex-type">' + $sanitize(exceptions[index].type) + '</span>';
3737
if (exceptions[index].message) {
38-
header += '<span class="ex-message">: ' + exceptions[index].message + '</span>';
38+
header += '<span class="ex-message">: ' + $sanitize(exceptions[index].message) + '</span>';
3939
}
4040

4141
header += '</span>';

src/components/stack-trace/stack-trace-directive.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
angular.module('exceptionless.stack-trace', [
55
'exceptionless.error'
66
])
7-
.directive('stackTrace', ['errorService', function (errorService) {
7+
.directive('stackTrace', ['$sanitize', 'errorService', function ($sanitize, errorService) {
88
function buildParameter(parameter) {
99
var result = '';
1010

@@ -71,7 +71,7 @@
7171
}
7272
}
7373

74-
return result + '\r\n';
74+
return $sanitize(result + '\r\n');
7575
}
7676

7777
function buildStackFrames(exceptions) {
@@ -112,9 +112,9 @@
112112
header += ' ---> ';
113113
}
114114

115-
header += '<span class="ex-type">' + exceptions[index].type + '</span>';
115+
header += '<span class="ex-type">' + $sanitize(exceptions[index].type) + '</span>';
116116
if (exceptions[index].message) {
117-
header += '<span class="ex-message">: ' + exceptions[index].message + '</span>';
117+
header += '<span class="ex-message">: ' + $sanitize(exceptions[index].message) + '</span>';
118118
}
119119

120120
header += '</span>';

0 commit comments

Comments
 (0)