From 43a34cd803db786551702b5599cfa7f1c9f2a765 Mon Sep 17 00:00:00 2001 From: Abhishek Kaushik Date: Wed, 12 Mar 2025 14:16:01 +0530 Subject: [PATCH 1/2] Correct UK dialing code and fix typo in the International Calling Connoisseur instructions --- .../international-calling-connoisseur/.docs/instructions.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/exercises/concept/international-calling-connoisseur/.docs/instructions.md b/exercises/concept/international-calling-connoisseur/.docs/instructions.md index dc3934e28..e8f728f0f 100644 --- a/exercises/concept/international-calling-connoisseur/.docs/instructions.md +++ b/exercises/concept/international-calling-connoisseur/.docs/instructions.md @@ -63,12 +63,12 @@ dialingCodes.addNewDialingCode(39, "Vatican City"); Its rare, but mistakes can be made. To correct the mistake, we will need to know what dialing code the country is currently mapped to. -To find which dialing code needs to be corrected, implement the `findDialingCode` method that takes in a map of dialing codes an a country and returns the country's dialing code. +To find which dialing code needs to be corrected, implement the `findDialingCode` method that takes in a map of dialing codes and a country and returns the country's dialing code. Return `null` if the country is _not_ in the map. ```java DialingCodes dialingCodes = new DialingCodes(); -dialingCodes.addDialingCode(43, "UK"); +dialingCodes.addDialingCode(44, "UK"); dialingCodes.findDialingCode("UK"); // => 44 From 8e185046bdae04a57fff190eb11c22cf0c501f01 Mon Sep 17 00:00:00 2001 From: Abhishek Kaushik Date: Wed, 12 Mar 2025 21:34:58 +0530 Subject: [PATCH 2/2] Fix the UK dialing code in the tests as well --- .../src/test/java/DialingCodesTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/exercises/concept/international-calling-connoisseur/src/test/java/DialingCodesTest.java b/exercises/concept/international-calling-connoisseur/src/test/java/DialingCodesTest.java index 5d97a48bf..e88e7379f 100644 --- a/exercises/concept/international-calling-connoisseur/src/test/java/DialingCodesTest.java +++ b/exercises/concept/international-calling-connoisseur/src/test/java/DialingCodesTest.java @@ -113,9 +113,9 @@ public void testAddNewDialingCodeLeavesExistingCountry() { @DisplayName("findDialingCode returns a country's dialing code") public void testFindDialingCode() { DialingCodes dialingCodes = new DialingCodes(); - dialingCodes.addNewDialingCode(43, "UK"); + dialingCodes.addNewDialingCode(44, "UK"); - assertThat(dialingCodes.findDialingCode("UK")).isEqualTo(43); + assertThat(dialingCodes.findDialingCode("UK")).isEqualTo(44); } @Test @@ -123,7 +123,7 @@ public void testFindDialingCode() { @DisplayName("findDialingCode returns null for country not yet added") public void testFindDialingCodeWithUnlistedCountry() { DialingCodes dialingCodes = new DialingCodes(); - dialingCodes.addNewDialingCode(43, "UK"); + dialingCodes.addNewDialingCode(44, "UK"); assertThat(dialingCodes.findDialingCode("Unlisted")).isNull(); }