From 5b0faa42c3d685beab3c3bc34cc00419d7f3b83e Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Fri, 6 Jun 2025 00:23:42 +0530 Subject: [PATCH 1/2] Syncing test.toml and updating the test code --- .../practice/largest-series-product/.meta/tests.toml | 10 ++++++++++ .../largest-series-product.spec.js | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/exercises/practice/largest-series-product/.meta/tests.toml b/exercises/practice/largest-series-product/.meta/tests.toml index 8831692597..982f517cc3 100644 --- a/exercises/practice/largest-series-product/.meta/tests.toml +++ b/exercises/practice/largest-series-product/.meta/tests.toml @@ -38,6 +38,11 @@ description = "reports zero if all spans include zero" [5d81aaf7-4f67-4125-bf33-11493cc7eab7] description = "rejects span longer than string length" +include = false + +[0ae1ce53-d9ba-41bb-827f-2fceb64f058b] +description = "rejects span longer than string length" +reimplements = "5d81aaf7-4f67-4125-bf33-11493cc7eab7" [06bc8b90-0c51-4c54-ac22-3ec3893a079e] description = "reports 1 for empty string and empty product (0 span)" @@ -49,6 +54,11 @@ include = false [6d96c691-4374-4404-80ee-2ea8f3613dd4] description = "rejects empty string and nonzero span" +include = false + +[6cf66098-a6af-4223-aab1-26aeeefc7402] +description = "rejects empty string and nonzero span" +reimplements = "6d96c691-4374-4404-80ee-2ea8f3613dd4" [7a38f2d6-3c35-45f6-8d6f-12e6e32d4d74] description = "rejects invalid character in digits" diff --git a/exercises/practice/largest-series-product/largest-series-product.spec.js b/exercises/practice/largest-series-product/largest-series-product.spec.js index a96e650ec7..bfb6560b5c 100644 --- a/exercises/practice/largest-series-product/largest-series-product.spec.js +++ b/exercises/practice/largest-series-product/largest-series-product.spec.js @@ -42,13 +42,13 @@ describe('Largest Series Product', () => { xtest('rejects span longer than string length', () => { expect(() => largestProduct('123', 4)).toThrow( - new Error('span must be smaller than string length'), + new Error('span must not exceed string length'), ); }); xtest('rejects empty string and nonzero span', () => { expect(() => largestProduct('', 1)).toThrow( - new Error('span must be smaller than string length'), + new Error('span must not exceed string length'), ); }); From 59e20ba78124020875b75dcf7dd02fdd66d43756 Mon Sep 17 00:00:00 2001 From: Jagdish Prajapati Date: Fri, 6 Jun 2025 09:24:38 +0530 Subject: [PATCH 2/2] Updating proof solution [no important files changed] --- exercises/practice/largest-series-product/.meta/proof.ci.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/practice/largest-series-product/.meta/proof.ci.js b/exercises/practice/largest-series-product/.meta/proof.ci.js index facec74de4..4f34d946f8 100644 --- a/exercises/practice/largest-series-product/.meta/proof.ci.js +++ b/exercises/practice/largest-series-product/.meta/proof.ci.js @@ -3,7 +3,7 @@ export const largestProduct = (digits, seriesLength) => { return 1; } if (seriesLength > digits.length) { - throw new Error('span must be smaller than string length'); + throw new Error('span must not exceed string length'); } if (seriesLength < 0) { throw new Error('span must not be negative');