From 2a0146b4a0700bc0a06d23671a7d45633ad03e6b Mon Sep 17 00:00:00 2001 From: meatball Date: Sun, 31 Aug 2025 23:22:19 +0200 Subject: [PATCH 1/2] Fix verification script + bug fix --- bin/generate | 8 +++----- exercises/practice/atbash-cipher/.meta/test_template.erb | 4 ++-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/bin/generate b/bin/generate index 4966be4299..5cf53e22ae 100755 --- a/bin/generate +++ b/bin/generate @@ -16,8 +16,8 @@ end class VerificationError < StandardError MESSAGE = 'The result generated for %s, does not match the current file' - def initialize(message = MESSAGE) - super + def initialize(exercise, message = MESSAGE) + super(message % { exercise: exercise }) end end @@ -48,10 +48,8 @@ parser.on('--verify', 'Verify all exercises') do Generator.new(exercise).generate(f.path) generated_code = f.read File.delete(f.path) - fail VerificationError unless current_code == generated_code + fail VerificationError.new(exercise) unless current_code == generated_code end - rescue VerificationError => e - STDERR.puts e.message % {exercise:} end end diff --git a/exercises/practice/atbash-cipher/.meta/test_template.erb b/exercises/practice/atbash-cipher/.meta/test_template.erb index f0f0ac9e1e..fe4a74926e 100644 --- a/exercises/practice/atbash-cipher/.meta/test_template.erb +++ b/exercises/practice/atbash-cipher/.meta/test_template.erb @@ -1,7 +1,7 @@ require 'minitest/autorun' -require_relative 'armstrong_numbers' +require_relative 'atbash_cipher' -class ArmstrongNumbersTest < Minitest::Test +class AtbashCipherTest < Minitest::Test <% json["cases"].each do |cases| %> <% cases["cases"].each do |sub_case| %> def test_<%= underscore(sub_case["description"]) %> From 0930fbd79e9c9e8a4474df96236742c1d32ab135 Mon Sep 17 00:00:00 2001 From: meatball <69751659+meatball133@users.noreply.github.com> Date: Tue, 2 Sep 2025 19:50:29 +0200 Subject: [PATCH 2/2] Update bin/generate Co-authored-by: Victor Goff --- bin/generate | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/generate b/bin/generate index 5cf53e22ae..cd72e31e5e 100755 --- a/bin/generate +++ b/bin/generate @@ -48,7 +48,7 @@ parser.on('--verify', 'Verify all exercises') do Generator.new(exercise).generate(f.path) generated_code = f.read File.delete(f.path) - fail VerificationError.new(exercise) unless current_code == generated_code + fail VerificationError, exercise unless current_code == generated_code end end end