Implement Drop as a safeguard for programmer errors (#618)

It addresses #605

Author: Maciej Witowski

actors/datacap/tests/datacap_actor_test.rs

@@ -87,6 +87,7 @@ mod mint {
             "must be a multiple of 1000000000000000000",
             h.mint(&mut rt, &*ALICE, &amt, vec![]),
         );
+        rt.reset();
         h.check_state(&rt);
     }
 

actors/miner/tests/batch_method_network_fees_test.rs

@@ -64,6 +64,7 @@ fn insufficient_funds_for_aggregated_prove_commit_network_fee() {
     );
 
     expect_abort(ExitCode::USR_INSUFFICIENT_FUNDS, res);
+    rt.reset();
 }
 
 #[test]
@@ -112,6 +113,7 @@ fn insufficient_funds_for_batch_precommit_network_fee() {
         "unlocked balance can not repay fee debt",
         res,
     );
+    rt.reset();
 }
 
 #[test]
@@ -167,6 +169,7 @@ fn insufficient_funds_for_batch_precommit_in_combination_of_fee_debt_and_network
         "unlocked balance can not repay fee debt",
         res,
     );
+    rt.reset();
 }
 
 #[test]
@@ -215,6 +218,7 @@ fn enough_funds_for_fee_debt_and_network_fee_but_not_for_pcd() {
         "insufficient funds 0.0 for pre-commit deposit",
         res,
     );
+    rt.reset();
 
     // state untouched
     let state: State = rt.get_state();

actors/miner/tests/change_owner_address_test.rs

@@ -99,6 +99,7 @@ fn proposed_must_be_valid() {
     for nominee in nominees {
         let result = h.change_owner_address(&mut rt, nominee);
         expect_abort(ExitCode::USR_ILLEGAL_ARGUMENT, result);
+        rt.reset();
     }
 
     h.check_state(&rt);

actors/miner/tests/change_worker_address_test.rs

@@ -181,49 +181,47 @@ fn fails_if_control_addresses_length_exceeds_maximum_limit() {
         "control addresses length",
         result,
     );
+    rt.reset();
 
     h.check_state(&rt);
 }
 
 #[test]
 fn fails_if_unable_to_resolve_control_address() {
     let (h, mut rt) = setup();
-
     let control_address = new_bls_addr(42);
     let result = h.change_worker_address(&mut rt, h.worker, vec![control_address]);
     expect_abort(ExitCode::USR_ILLEGAL_ARGUMENT, result);
+    rt.reset();
 
     h.check_state(&rt);
 }
 
 #[test]
 fn fails_if_unable_to_resolve_worker_address() {
     let (h, mut rt) = setup();
-
     let new_worker = new_bls_addr(42);
     let result = h.change_worker_address(&mut rt, new_worker, vec![]);
     expect_abort(ExitCode::USR_ILLEGAL_ARGUMENT, result);
-
+    rt.reset();
     h.check_state(&rt);
 }
 
 #[test]
 fn fails_if_worker_public_key_is_not_bls_but_id() {
     let (mut h, mut rt) = setup();
-
     let new_worker = Address::new_id(999);
     h.worker_key = Address::new_id(505);
 
     let result = h.change_worker_address(&mut rt, new_worker, vec![]);
     expect_abort(ExitCode::USR_ILLEGAL_ARGUMENT, result);
-
+    rt.reset();
     h.check_state(&rt);
 }
 
 #[test]
 fn fails_if_worker_public_key_is_not_bls_but_secp() {
     let (mut h, mut rt) = setup();
-
     let new_worker = Address::new_id(999);
     h.worker_key = Address::new_secp256k1(&[0x42; 65]).unwrap();
 

actors/miner/tests/compact_partitions_test.rs

@@ -194,7 +194,7 @@ fn fails_if_deadline_out_of_range() {
         &format!("invalid deadline {w_post_period_deadlines}"),
         result,
     );
-
+    rt.reset();
     h.check_state(&rt);
 }
 

actors/miner/tests/compact_sector_numbers_tests.rs

@@ -116,14 +116,13 @@ mod compact_sector_numbers_test {
                 bitfield_from_slice(&[target_sector_num, target_sector_num + 1]),
             ),
         );
-
+        rt.reset();
         check_state_invariants_from_mock_runtime(&rt);
     }
 
     #[test]
     fn sector_number_range_limits() {
         let (h, mut rt) = setup();
-
         // Limits ok
         h.compact_sector_numbers(&mut rt, h.worker, bitfield_from_slice(&[0, MAX_SECTOR_NUMBER]));
 
@@ -136,18 +135,19 @@ mod compact_sector_numbers_test {
                 bitfield_from_slice(&[MAX_SECTOR_NUMBER + 1]),
             ),
         );
+        rt.reset();
         check_state_invariants_from_mock_runtime(&rt);
     }
 
     #[test]
     fn compacting_no_sector_numbers_aborts() {
         let (h, mut rt) = setup();
-
         expect_abort(
             ExitCode::USR_ILLEGAL_ARGUMENT,
             // compact nothing
             h.compact_sector_numbers_raw(&mut rt, h.worker, bitfield_from_slice(&[])),
         );
+        rt.reset();
         check_state_invariants_from_mock_runtime(&rt);
     }
 }

actors/miner/tests/declare_recoveries.rs

@@ -53,6 +53,7 @@ fn recovery_must_pay_back_fee_debt() {
     let (mut h, mut rt) = setup();
     let one_sector =
         h.commit_and_prove_sectors(&mut rt, 1, DEFAULT_SECTOR_EXPIRATION as u64, vec![], true);
+
     // advance to first proving period and submit so we'll have time to declare the fault next cycle
     h.advance_and_submit_posts(&mut rt, &one_sector);
 

actors/miner/tests/extend_sector_expiration_test.rs

@@ -769,6 +769,7 @@ fn update_expiration_legacy_fails_on_new_sector_with_deals() {
         "cannot use legacy sector extension for simple qa power with deal weight",
         h.extend_sectors(&mut rt, params),
     );
+    rt.reset();
     check_for_expiration(
         &mut h,
         &mut rt,

actors/miner/tests/miner_actor_test_commitment.rs

@@ -112,6 +112,7 @@ mod miner_actor_test_commitment {
         let mut h = ActorHarness::new(period_offset);
         h.set_proof_type(RegisteredSealProof::StackedDRG64GiBV1);
         let mut rt = h.new_runtime();
+
         rt.set_balance(insufficient_balance);
         rt.set_received(TokenAmount::zero());
 
@@ -129,6 +130,7 @@ mod miner_actor_test_commitment {
             ExitCode::USR_INSUFFICIENT_FUNDS,
             h.pre_commit_sector(&mut rt, precommit_params, util::PreCommitConfig::default(), true),
         );
+        rt.reset();
         h.check_state(&rt);
     }
 
@@ -169,6 +171,7 @@ mod miner_actor_test_commitment {
 
         let mut h = ActorHarness::new(period_offset);
         let mut rt = h.new_runtime();
+
         rt.set_balance(BIG_BALANCE.clone());
         rt.set_received(TokenAmount::zero());
 
@@ -468,6 +471,7 @@ mod miner_actor_test_commitment {
             let mut h = ActorHarness::new(period_offset);
             h.set_proof_type(proof);
             let mut rt = h.new_runtime();
+
             rt.set_balance(BIG_BALANCE.clone());
             rt.set_received(TokenAmount::zero());
 
@@ -508,6 +512,7 @@ mod miner_actor_test_commitment {
                 "too many deals for sector",
                 ret,
             );
+            rt.reset();
 
             // sector at or below limit succeeds
             let (mut rt, h, _) = setup(proof);
@@ -533,6 +538,7 @@ mod miner_actor_test_commitment {
 
         let h = ActorHarness::new(period_offset);
         let mut rt = h.new_runtime();
+
         rt.set_balance(BIG_BALANCE.clone());
         rt.set_received(TokenAmount::zero());
 

actors/miner/tests/miner_actor_test_precommit_batch.rs

@@ -282,6 +282,7 @@ mod miner_actor_precommit_batch {
         });
 
         let mut rt = h.new_runtime();
+
         rt.set_balance(BIG_BALANCE.clone());
         rt.set_received(TokenAmount::zero());
 
@@ -321,6 +322,7 @@ mod miner_actor_precommit_batch {
             proving_period_offset: period_offset,
         });
         let mut rt = h.new_runtime();
+
         rt.set_balance(BIG_BALANCE.clone());
         rt.set_received(TokenAmount::zero());
 
@@ -359,6 +361,7 @@ mod miner_actor_precommit_batch {
             proving_period_offset: period_offset,
         });
         let mut rt = h.new_runtime();
+
         rt.set_balance(BIG_BALANCE.clone());
         rt.set_received(TokenAmount::zero());
 
@@ -433,6 +436,7 @@ mod miner_actor_precommit_batch {
                 "and passed CompactCommD",
                 result,
             );
+            rt.reset();
         }
     }
 }