Fix: Fixed an issue with dropping multiple items onto executable files (#14067)

Author: antonioseet

src/Files.App/Helpers/Environment/SoftwareHelpers.cs

@@ -2,6 +2,7 @@
 // Licensed under the MIT License. See the LICENSE.
 
 using Microsoft.Win32;
+using System.IO;
 
 namespace Files.App.Helpers
 {
@@ -30,6 +31,32 @@ public static bool IsVSInstalled()
 			return true;
 		}
 
+		public static bool IsPythonInstalled()
+		{
+			try
+			{
+				ProcessStartInfo psi = new ProcessStartInfo();
+				psi.FileName = "python";
+				psi.Arguments = "--version";
+				psi.RedirectStandardOutput = true;
+				psi.UseShellExecute = false;
+				psi.CreateNoWindow = true;
+
+				using (Process process = Process.Start(psi))
+				{
+					using (StreamReader reader = process.StandardOutput)
+					{
+						string result = reader.ReadToEnd();
+						return result.Contains("Python");
+					}
+				}
+			}
+			catch
+			{
+				return false;
+			}
+		}
+
 		private static bool ContainsName(RegistryKey? key, string find)
 		{
 			if (key is null)

src/Files.App/Helpers/Navigation/NavigationHelpers.cs

@@ -321,42 +321,15 @@ public static async Task OpenSelectedItemsAsync(IShellPage associatedInstance, b
 			}
 		}
 
-		public static async Task OpenItemsWithExecutableAsync(IShellPage associatedInstance, IEnumerable<IStorageItemWithPath> items, string executable)
+		public static async Task OpenItemsWithExecutableAsync(IShellPage associatedInstance, IEnumerable<IStorageItemWithPath> items, string executablePath)
 		{
 			// Don't open files and folders inside recycle bin
 			if (associatedInstance.FilesystemViewModel.WorkingDirectory.StartsWith(Constants.UserEnvironmentPaths.RecycleBinPath, StringComparison.Ordinal) ||
 				associatedInstance.SlimContentPage is null)
-			{
 				return;
-			}
-
-			foreach (var item in items)
-			{
-				try
-				{
-					await OpenPath(executable, associatedInstance, FilesystemItemType.File, false, false, args: $"\"{item.Path}\"");
-				}
-				catch (Exception e)
-				{
-					// This is to try and figure out the root cause of AppCenter error #985932119u
-					App.Logger.LogWarning(e, e.Message);
-				}
-			}
-		}
 
-		public static async Task OpenItemsWithPythonAsync(IShellPage associatedInstance, IEnumerable<IStorageItemWithPath> items, string pythonScriptPath)
-		{
-			// Don't open files and folders inside recycle bin
-			if (associatedInstance.FilesystemViewModel.WorkingDirectory.StartsWith(Constants.UserEnvironmentPaths.RecycleBinPath, StringComparison.Ordinal) ||
-								associatedInstance.SlimContentPage is null)
-			{
-				return;
-			}
-
-			foreach (var item in items)
-			{
-				await Win32Helpers.InvokeWin32ComponentAsync(pythonScriptPath, associatedInstance, arguments: $"\"{item.Path}\"");
-			}
+			var arguments = string.Join(" ", items.Select(item => $"\"{item.Path}\""));
+			await Win32Helpers.InvokeWin32ComponentAsync(executablePath, associatedInstance, arguments);
 		}
 
 		/// <summary>

src/Files.App/Utils/Storage/Operations/FilesystemHelpers.cs

@@ -255,18 +255,14 @@ public async Task<ReturnResult> PerformOperationTypeAsync(
 				else if (operation.HasFlag(DataPackageOperation.Link))
 				{
 					// Open with piggybacks off of the link operation, since there isn't one for it
-					if (isTargetExecutable)
+					if (isTargetExecutable || isTargetPythonFile)
 					{
 						var items = await GetDraggedStorageItems(packageView);
+						if (isTargetPythonFile && !SoftwareHelpers.IsPythonInstalled())
+							return ReturnResult.Cancelled;
 						NavigationHelpers.OpenItemsWithExecutableAsync(associatedInstance, items, destination);
 						return ReturnResult.Success;
 					}
-					else if (isTargetPythonFile)
-					{
-						var items = await GetDraggedStorageItems(packageView);
-						NavigationHelpers.OpenItemsWithPythonAsync(associatedInstance, items, destination);
-						return ReturnResult.Success;
-					}
 					else
 					{
 						return await CreateShortcutFromClipboard(packageView, destination, showDialog, registerHistory);

src/Files.App/Views/Layouts/BaseLayoutPage.cs

@@ -1259,7 +1259,9 @@ protected void InitializeDrag(UIElement container, ListedItem item)
 				return;
 
 			UninitializeDrag(container);
-			if ((item.PrimaryItemAttribute == StorageItemTypes.Folder && !RecycleBinHelpers.IsPathUnderRecycleBin(item.ItemPath)) || item.IsExecutable || item.IsPythonFile)
+			if ((item.PrimaryItemAttribute == StorageItemTypes.Folder && !RecycleBinHelpers.IsPathUnderRecycleBin(item.ItemPath))
+				|| item.IsExecutable
+				|| item.IsPythonFile)
 			{
 				container.AllowDrop = true;
 				container.AddHandler(UIElement.DragOverEvent, Item_DragOverEventHandler, true);