Skip to content

Commit 5487e22

Browse files
committed
test(vmclock): enable skipped tests
We now apply backported patches that add support for VMClock on Aarch64 systems via DT bindings, so enable tests for Aarch64 as well. Moreover, backported patches add support for the poll() system calls family, so enable the relevant test. Signed-off-by: Babis Chalios <bchalios@amazon.es>
1 parent dd11728 commit 5487e22

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

tests/integration_tests/functional/test_vmclock.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
# SPDX-License-Identifier: Apache-2.0
33
"""Test VMclock device emulation"""
44

5-
import platform
6-
75
import pytest
86

97

@@ -50,10 +48,6 @@ def parse_vmclock_from_poll(vm, expected_notifications):
5048
return dict(item.split(": ") for item in fields if item.startswith("VMCLOCK"))
5149

5250

53-
@pytest.mark.skipif(
54-
platform.machine() != "x86_64",
55-
reason="VMClock device is currently supported only on x86 systems",
56-
)
5751
@pytest.mark.parametrize("use_mmap", [False, True], ids=["read()", "mmap()"])
5852
def test_vmclock_read_fields(vm_with_vmclock, use_mmap):
5953
"""Make sure that we expose the expected values in the VMclock struct"""
@@ -71,10 +65,6 @@ def test_vmclock_read_fields(vm_with_vmclock, use_mmap):
7165
assert vmclock["VMCLOCK_VM_GENERATION_COUNTER"] == "0"
7266

7367

74-
@pytest.mark.skipif(
75-
platform.machine() != "x86_64",
76-
reason="VMClock device is currently supported only on x86 systems",
77-
)
7868
@pytest.mark.parametrize("use_mmap", [False, True], ids=["read()", "mmap()"])
7969
def test_snapshot_update(vm_with_vmclock, microvm_factory, snapshot_type, use_mmap):
8070
"""Test that `disruption_marker` and `vm_generation_counter` are updated
@@ -98,10 +88,6 @@ def test_snapshot_update(vm_with_vmclock, microvm_factory, snapshot_type, use_mm
9888
assert vmclock["VMCLOCK_VM_GENERATION_COUNTER"] == f"{i+1}"
9989

10090

101-
# TODO: remove this skip when we backport VMClock snapshot safety patches to 5.10 and 6.1
102-
@pytest.mark.skip(
103-
reason="Skip until we get guest microVM kernels with support for the notification mechanism",
104-
)
10591
def test_vmclock_notifications(vm_with_vmclock, microvm_factory, snapshot_type):
10692
"""Test that Firecracker will send a notification on snapshot load"""
10793
basevm = vm_with_vmclock

0 commit comments

Comments
 (0)