Skip to content

Commit 5ac5e4a

Browse files
committed
release fixes
1 parent d0e3fbe commit 5ac5e4a

File tree

4 files changed

+16
-15
lines changed

4 files changed

+16
-15
lines changed

.github/workflows/build.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,27 +40,27 @@ jobs:
4040
- name: Upload firefox extension as build artifact
4141
uses: actions/upload-artifact@v1
4242
with:
43-
name: ${{ env.FIREPHP_BUILD_FILENAME_PREFIX }}-firefox
44-
path: dist/${{ env.FIREPHP_BUILD_FILENAME_PREFIX }}-firefox.zip
43+
name: firephp-firefox
44+
path: dist/firephp-firefox.zip
4545

4646
- name: Upload chrome extension as build artifact
4747
uses: actions/upload-artifact@v1
4848
with:
49-
name: ${{ env.FIREPHP_BUILD_FILENAME_PREFIX }}-chrome
50-
path: dist/${{ env.FIREPHP_BUILD_FILENAME_PREFIX }}-chrome.zip
49+
name: firephp-chrome
50+
path: dist/firephp-chrome.zip
5151

5252
- name: Upload firefox release (if tagging)
5353
uses: fnkr/github-action-ghr@v1
5454
if: startsWith(github.ref, 'refs/tags/')
5555
env:
56-
GHR_PATH: dist/${{ env.FIREPHP_BUILD_FILENAME_PREFIX }}-firefox
56+
GHR_PATH: dist/firephp-firefox
5757
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5858

5959
- name: Upload chrome release (if tagging)
6060
uses: fnkr/github-action-ghr@v1
6161
if: startsWith(github.ref, 'refs/tags/')
6262
env:
63-
GHR_PATH: dist/${{ env.FIREPHP_BUILD_FILENAME_PREFIX }}-chrome
63+
GHR_PATH: dist/firephp-chrome
6464
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6565

6666
- name: "[sm.act] Write snapshot report"

.postbuild.sh

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,14 @@ popd > /dev/null
4141
pushd "dist" > /dev/null
4242

4343
filename="firephp"
44-
if [ ! -z "${SM_ACT_GIT_BRANCH}" ]; then
45-
filename="${filename}-${SM_ACT_GIT_BRANCH}-${SM_ACT_GIT_SHA3}"
46-
else
47-
filename="${filename}-${SM_ACT_GIT_TAG}"
48-
fi
49-
50-
echo "::set-env name=FIREPHP_BUILD_FILENAME_PREFIX::${filename}"
44+
# NOTE: We always keep the directory named the same.
45+
# Different directory and archive names can be used by a distribution service.
46+
# if [ ! -z "${SM_ACT_GIT_BRANCH}" ]; then
47+
# filename="${filename}-${SM_ACT_GIT_BRANCH}-${SM_ACT_GIT_SHA3}"
48+
# else
49+
# filename="${filename}-${SM_ACT_GIT_TAG}"
50+
# fi
51+
# echo "FIREPHP_BUILD_FILENAME_PREFIX=${filename}" >> $GITHUB_ENV
5152

5253
pushd "firephp.build.firefox" > /dev/null
5354
zip -r "../${filename}-firefox.zip" * --exclude '.DS_Store'

npm-shrinkwrap.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "firephp-for-browser-devtools",
3-
"version": "1.5.5",
3+
"version": "1.5.6",
44
"devDependencies": {
55
"codemirror": "^5.49.0",
66
"eventemitter2": "^4.1.2",

0 commit comments

Comments
 (0)