make 'and' validator immutable

Author: ArturAssisComp

lib/src/form_builder_validators.dart

@@ -1784,7 +1784,6 @@ final class Validators {
   /// - [ArgumentError] if `validators` is empty
   /// {@endtemplate}
   static Validator<T> and<T extends Object>(
-    // TODO(ArturAssisComp): refactor to make this input immutable.
     List<Validator<T>> validators, {
     String prefix = '',
     String suffix = '',
@@ -4159,14 +4158,11 @@ final class Validators {
   /// ```
   /// {@endtemplate}
   static Validator<String> url({
-    // TODO(ArturAssisComp): refactor to make this input immutable.
     List<String> protocols = val.kDefaultUrlValidationProtocols,
     bool requireTld = true,
     bool requireProtocol = false,
     bool allowUnderscore = false,
-    // TODO(ArturAssisComp): refactor to make this input immutable.
     List<String> hostAllowList = const <String>[],
-    // TODO(ArturAssisComp): refactor to make this input immutable.
     List<String> hostBlockList = const <String>[],
     RegExp? regex,
     String Function(String input)? urlMsg,

lib/src/validators/core_validators/compose_validators.dart

@@ -14,9 +14,11 @@ Validator<T> and<T extends Object>(
     throw ArgumentError.value(
         '[]', 'validators', 'The list of validators must not be empty');
   }
+  final List<Validator<T>> immutableValidators =
+      List<Validator<T>>.unmodifiable(validators);
   return (T value) {
     final List<String> errorMessageBuilder = <String>[];
-    for (final Validator<T> validator in validators) {
+    for (final Validator<T> validator in immutableValidators) {
       final String? errorMessage = validator(value);
       if (errorMessage != null) {
         if (printErrorAsSoonAsPossible) {

test/src/validators/core_validators/composition_validators/and_validator_test.dart

@@ -135,5 +135,29 @@ void main() {
     test('Should throw AssertionError when the validators input is empty', () {
       expect(() => and(<Validator<Object?>>[]), throwsArgumentError);
     });
+
+    test('should be immutable even when input validators change', () {
+      final List<String? Function(double)> validators =
+          <String? Function(double)>[gt(12), ltE(15)];
+
+      final Validator<double> v = and(validators);
+      expect(v(12), errorGt);
+      expect(v(13), isNull);
+      expect(v(15), isNull);
+      expect(v(16.5), errorLtE);
+
+      validators.add(gt(13));
+      expect(v(12), errorGt);
+      expect(v(13), isNull);
+      expect(v(15), isNull);
+      expect(v(16.5), errorLtE);
+
+      validators.removeLast();
+      validators.removeLast();
+      expect(v(12), errorGt);
+      expect(v(13), isNull);
+      expect(v(15), isNull);
+      expect(v(16.5), errorLtE);
+    });
   });
 }