From d80266525f72b66202a18af3fc5868baaf6dd9f6 Mon Sep 17 00:00:00 2001 From: Frank Dekker Date: Sun, 30 Nov 2025 14:47:25 +0100 Subject: [PATCH 1/4] Add php8.5 to the matrix --- .github/workflows/test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 865812d8..3dcef34c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -15,7 +15,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - php-version: [ '8.1', '8.2', '8.3', '8.4' ] + php-version: [ '8.1', '8.2', '8.3', '8.4', '8.5' ] composer-flags: [ '', '--prefer-lowest' ] exclude: - php-version: '8.4' @@ -39,7 +39,7 @@ jobs: run: composer test coverage: - name: PHP 8.4 - Test with coverage + name: PHP 8.5 - Test with coverage runs-on: ubuntu-latest steps: - uses: actions/checkout@v6 @@ -47,7 +47,7 @@ jobs: - name: Setup PHP uses: shivammathur/setup-php@v2 with: - php-version: 8.4 + php-version: 8.5 coverage: pcov - name: Install dependencies @@ -74,7 +74,7 @@ jobs: - name: Setup PHP uses: shivammathur/setup-php@v2 with: - php-version: 8.1 + php-version: 8.5 coverage: none - name: Install dependencies From ead3918b65d109b5cff60ceb82884d5b84033f03 Mon Sep 17 00:00:00 2001 From: Frank Dekker Date: Sun, 30 Nov 2025 14:51:13 +0100 Subject: [PATCH 2/4] Add php8.5 to the matrix --- .github/workflows/test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3dcef34c..899417de 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -20,6 +20,8 @@ jobs: exclude: - php-version: '8.4' composer-flags: '--prefer-lowest' + - php-version: '8.5' + composer-flags: '--prefer-lowest' steps: - uses: actions/checkout@v6 From c0dfeb208ba8256c4ffcd2c5c5d31dec7b062c46 Mon Sep 17 00:00:00 2001 From: Frank Dekker Date: Sun, 30 Nov 2025 15:04:21 +0100 Subject: [PATCH 3/4] Fix phpstan types for PHP8.5 --- src/DependencyInjection/Configuration.php | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php index b1f184e2..dd3470d8 100644 --- a/src/DependencyInjection/Configuration.php +++ b/src/DependencyInjection/Configuration.php @@ -16,10 +16,12 @@ */ final class Configuration implements ConfigurationInterface { + /** + * @return TreeBuilder<'array'> + */ public function getConfigTreeBuilder(): TreeBuilder { - $tree = new TreeBuilder('fd_log_viewer'); - /** @var ArrayNodeDefinition $rootNode */ + $tree = new TreeBuilder('fd_log_viewer'); $rootNode = $tree->getRootNode(); $rootNode @@ -31,10 +33,12 @@ public function getConfigTreeBuilder(): TreeBuilder return $tree; } - private function configureLogFiles(): NodeDefinition + /** + * @return ArrayNodeDefinition + */ + private function configureLogFiles(): ArrayNodeDefinition { - $tree = new TreeBuilder('log_files'); - /** @var ArrayNodeDefinition $rootNode */ + $tree = new TreeBuilder('log_files'); $rootNode = $tree->getRootNode(); return $rootNode @@ -113,10 +117,12 @@ private function configureLogFiles(): NodeDefinition ->end(); } - private function configureHosts(): NodeDefinition + /** + * @return ArrayNodeDefinition + */ + private function configureHosts(): ArrayNodeDefinition { - $tree = new TreeBuilder('hosts'); - /** @var ArrayNodeDefinition $rootNode */ + $tree = new TreeBuilder('hosts'); $rootNode = $tree->getRootNode(); return $rootNode From db6db31832c39f0a18f859b56f9b38fb3170b9af Mon Sep 17 00:00:00 2001 From: Frank Dekker Date: Sun, 30 Nov 2025 15:05:20 +0100 Subject: [PATCH 4/4] Fix phpstan types for PHP8.5 --- src/DependencyInjection/Configuration.php | 1 - 1 file changed, 1 deletion(-) diff --git a/src/DependencyInjection/Configuration.php b/src/DependencyInjection/Configuration.php index dd3470d8..74cbe2c1 100644 --- a/src/DependencyInjection/Configuration.php +++ b/src/DependencyInjection/Configuration.php @@ -7,7 +7,6 @@ use Closure; use FD\LogViewer\Service\File\Monolog\MonologLineParser; use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition; -use Symfony\Component\Config\Definition\Builder\NodeDefinition; use Symfony\Component\Config\Definition\Builder\TreeBuilder; use Symfony\Component\Config\Definition\ConfigurationInterface;