Replies: 3 comments 1 reply
-
|
@ISSOtm Given that you were positive about this when we discussed it, I'd prefer to leave the initial steps to you. Basically:
|
Beta Was this translation helpful? Give feedback.
-
|
@avivace @ISSOtm Please note that I don't plan to be making these changes myself right now, because I don't think I can usefully contribute to gb-asm-tutorial in its current state. We have policies and expectations around how "maintainers" are responsible for approving PRs and being given time to do so, but as far as I can tell, the maintenance of gb-asm-tutorial is undefined.
Right now I do not know what long-term vision I should be targeting when making changes, because I suspect there isn't one, or that the contributors have disagreements about it. And if the contributors disagree about changes I propose or PR, it's not clear to me who's actually I don't want to start fights and drama, I want to contribute to a better tutorial, that we have a consensus on as far as what counts as "better". |
Beta Was this translation helpful? Give feedback.
-
|
I came across Modern Java (via lobste.rs), which may be useful for borrowing some structural ideas. In particular:
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Some of my recent issues and PRs, in particular #146 and the disagreement around when to introduce the relative-jump
jrinstruction, have sparked some broader discussion about the vision for what the completed tutorial will look like, and what sort of concepts it's meant to teach people.Not to put words in @ISSOtm 's mouth, but my understanding of his long-term plan has been:
"wrong"non-idiomatically/inefficiently at first, which provides motivation for why better approaches will be used later, even if those better approaches are more complicated or difficult.Personally I don't want to count on a long-term plan being successfully executed, and would rather make some smaller changes in the near term, with the goal of teaching more idiomatic code right off the bat:
jrand local labels in particular -- not actuallycall+ret, initializingspand using the stack is too much complexity at that point, that's fine where it is in the Unbricked project). I would also at least consider introducingINCBINand RGBGFX, even if it has to be manually invoked to create the graphics files, because it's just too cumbersome and unidiomatic to deal withdbed graphical data.jp-only, global-label-only, minimal project, just for the sake of getting something on-screen; but then Chapter II would critique its code and introduce better concepts right away, before the worse alternatives have set in as bad habits. And that way, the subsequent Unbricked and Galactic Armada projects would be able to usejr,.locals, etc, without having to pause and explain them.(Well, "I want to teach" is overstating it -- I am not interested in becoming an indefinite long-term maintainer for the whole gb-asm-tutorial. I think there's an opportunity here for some targeted finite changes to the existing structure, which would leave the existing "incomplete" tutorial better as a resource for teaching the sort of code that you actually see in real projects, and would hopefully make it easier for more authors to contribute to the tutorial, since they don't have to abide by so many restrictions around what hasn't been taught yet.)
Beta Was this translation helpful? Give feedback.
All reactions