Behaviour on bbox queries for providers that do not support them

[doublebyte1]

This issue is just to flag the fact that bbox queries issued against providers that do not support them, simply ignore the bbox parameter.

For example, in the case of the GeoJSON provider:

pygeoapi/pygeoapi/provider/geojson.py

Lines 156 to 158 in 451f1f0

	# TODO filter by bbox without resorting to third-party libs
	data = self._load(skip_geometry=skip_geometry, properties=properties,
	select_properties=select_properties)

Would it be more appropriated to throw a warning to the user, stating that the bbox filter is not implemented?

I am not sure if there is a rule on how to deal with this, or if this change would be consistent with the pygeoapi behaviour in other occasions, but I would love to hear more thoughts about this.

[tomkralidis]

Options:

• 1: emit LOGGER.warning (which would not emit to the client)
• 2: throw HTTP 501
• other options?

Having said this, somewhat related PR in #2058

[doublebyte1]

Options:

• 1: emit LOGGER.warning (which would not emit to the client)
• 2: throw HTTP 501
• other options?

Having said this, somewhat related PR in #2058

I find 501 a bit extreme, but silently failing is also not ideal. Maybe option 1 would be fine? It could even be LOGGER.error

[mikemahoney218-usgs]

I think a 501 is preferable -- otherwise as a user I'd assume that my query argument had done something. My other thought would be to not document the bbox parameter for these endpoints and then return a 400, indicating the user was using unavailable query arguments.

[tomkralidis]

Thanks @mikemahoney218-usgs for the feedback.

@doublebyte1 seeing that #2058 is now merged, do we have any remaining providers that do not support bbox? If so, we can close this issue.

[doublebyte1]

I think we can close it. Thank you @tomkralidis