Cleanup optional return vals in zod for staged indexes (#40217)

Now that conductor is pushed, we're clear!

GitOrigin-RevId: 8828081421e22e23ac72792058b41efec8cbedf9

Author: nipunn1313

src/cli/lib/components.ts

@@ -476,7 +476,7 @@ function printDiff(
       msg = msg.slice(0, -1); // strip last new line
       logFinishedStep(msg);
     }
-    if (rootDiff.enabled_indexes && rootDiff.enabled_indexes.length > 0) {
+    if (rootDiff.enabled_indexes.length > 0) {
       let msg = opts.dryRun
         ? `These indexes would be enabled:\n`
         : `These indexes are now enabled:\n`;
@@ -486,7 +486,7 @@ function printDiff(
       msg = msg.slice(0, -1); // strip last new line
       logFinishedStep(msg);
     }
-    if (rootDiff.disabled_indexes && rootDiff.disabled_indexes.length > 0) {
+    if (rootDiff.disabled_indexes.length > 0) {
       let msg = opts.dryRun
         ? `These indexes would be staged:\n`
         : `These indexes are now staged:\n`;

src/cli/lib/deploy2.ts

@@ -157,9 +157,9 @@ export async function waitForSchema(
           msg = `Backfilling indexes (${indexesComplete}/${indexesTotal} ready)...`;
           // Set a more specific message if the backfill is taking a long time
           if (Date.now() - start > 10_000) {
-            const rootDiff = startPush.schemaChange.indexDiffs?.[""];
+            const rootDiff = startPush.schemaChange.indexDiffs[""];
             const indexName = (
-              rootDiff?.added_indexes[0] || rootDiff?.enabled_indexes?.[0]
+              rootDiff.added_indexes[0] || rootDiff.enabled_indexes[0]
             )?.name;
             if (indexName) {
               const table = indexName.split(".")[0];

src/cli/lib/deployApi/finishPush.ts

@@ -73,8 +73,8 @@ export type DeveloperIndexConfig = z.infer<typeof developerIndexConfig>;
 export const indexDiff = looseObject({
   added_indexes: z.array(developerIndexConfig),
   removed_indexes: z.array(developerIndexConfig),
-  enabled_indexes: z.array(developerIndexConfig).optional(),
-  disabled_indexes: z.array(developerIndexConfig).optional(),
+  enabled_indexes: z.array(developerIndexConfig),
+  disabled_indexes: z.array(developerIndexConfig),
 });
 export type IndexDiff = z.infer<typeof indexDiff>;
 

src/cli/lib/deployApi/startPush.ts

@@ -27,7 +27,7 @@ export type StartPushRequest = z.infer<typeof startPushRequest>;
 export const schemaChange = looseObject({
   allocatedComponentIds: z.any(),
   schemaIds: z.any(),
-  indexDiffs: z.record(componentDefinitionPath, indexDiff).optional(),
+  indexDiffs: z.record(componentDefinitionPath, indexDiff),
 });
 export type SchemaChange = z.infer<typeof schemaChange>;