-
-
Notifications
You must be signed in to change notification settings - Fork 372
chore: Delete deprecated SentryPrivate #6995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6995 +/- ##
=============================================
+ Coverage 85.027% 85.049% +0.021%
=============================================
Files 453 453
Lines 27637 27637
Branches 12127 12131 +4
=============================================
+ Hits 23499 23505 +6
+ Misses 4092 4090 -2
+ Partials 46 42 -4 see 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f9270f9 | 1227.90 ms | 1253.24 ms | 25.34 ms |
| fa27d5b | 1195.50 ms | 1218.19 ms | 22.69 ms |
| b2295d4 | 1228.54 ms | 1264.81 ms | 36.27 ms |
| be9107c | 1223.63 ms | 1242.82 ms | 19.19 ms |
| 3c70f95 | 1210.62 ms | 1247.49 ms | 36.87 ms |
| f92cfa9 | 1228.45 ms | 1251.33 ms | 22.88 ms |
| f5d202b | 1237.90 ms | 1259.49 ms | 21.59 ms |
| 04f41a1 | 1215.82 ms | 1252.36 ms | 36.54 ms |
| 3ffd5bb | 1215.02 ms | 1236.88 ms | 21.86 ms |
| 7f4bf81 | 1241.73 ms | 1270.66 ms | 28.93 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f9270f9 | 24.14 KiB | 1.01 MiB | 1012.18 KiB |
| fa27d5b | 24.14 KiB | 1.01 MiB | 1015.38 KiB |
| b2295d4 | 24.14 KiB | 1.02 MiB | 1019.78 KiB |
| be9107c | 23.75 KiB | 975.19 KiB | 951.44 KiB |
| 3c70f95 | 24.14 KiB | 1.02 MiB | 1016.90 KiB |
| f92cfa9 | 23.75 KiB | 855.38 KiB | 831.62 KiB |
| f5d202b | 23.75 KiB | 904.53 KiB | 880.78 KiB |
| 04f41a1 | 24.14 KiB | 1.01 MiB | 1015.39 KiB |
| 3ffd5bb | 23.75 KiB | 1023.81 KiB | 1000.07 KiB |
| 7f4bf81 | 23.75 KiB | 919.70 KiB | 895.95 KiB |
…move_sentryprivate
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Removes
SentryPrivate.podspecsince it has been unused for over a year.Closes #7010