Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Dec 5, 2025

Removes SentryPrivate.podspec since it has been unused for over a year.

Closes #7010

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.049%. Comparing base (72a8c35) to head (6bc2035).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6995       +/-   ##
=============================================
+ Coverage   85.027%   85.049%   +0.021%     
=============================================
  Files          453       453               
  Lines        27637     27637               
  Branches     12127     12131        +4     
=============================================
+ Hits         23499     23505        +6     
+ Misses        4092      4090        -2     
+ Partials        46        42        -4     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a8c35...6bc2035. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1193.84 ms 1217.88 ms 24.04 ms
Size 24.14 KiB 1.02 MiB 1017.65 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f9270f9 1227.90 ms 1253.24 ms 25.34 ms
fa27d5b 1195.50 ms 1218.19 ms 22.69 ms
b2295d4 1228.54 ms 1264.81 ms 36.27 ms
be9107c 1223.63 ms 1242.82 ms 19.19 ms
3c70f95 1210.62 ms 1247.49 ms 36.87 ms
f92cfa9 1228.45 ms 1251.33 ms 22.88 ms
f5d202b 1237.90 ms 1259.49 ms 21.59 ms
04f41a1 1215.82 ms 1252.36 ms 36.54 ms
3ffd5bb 1215.02 ms 1236.88 ms 21.86 ms
7f4bf81 1241.73 ms 1270.66 ms 28.93 ms

App size

Revision Plain With Sentry Diff
f9270f9 24.14 KiB 1.01 MiB 1012.18 KiB
fa27d5b 24.14 KiB 1.01 MiB 1015.38 KiB
b2295d4 24.14 KiB 1.02 MiB 1019.78 KiB
be9107c 23.75 KiB 975.19 KiB 951.44 KiB
3c70f95 24.14 KiB 1.02 MiB 1016.90 KiB
f92cfa9 23.75 KiB 855.38 KiB 831.62 KiB
f5d202b 23.75 KiB 904.53 KiB 880.78 KiB
04f41a1 24.14 KiB 1.01 MiB 1015.39 KiB
3ffd5bb 23.75 KiB 1023.81 KiB 1000.07 KiB
7f4bf81 23.75 KiB 919.70 KiB 895.95 KiB

Previous results on branch: itay/remove_sentryprivate

Startup times

Revision Plain With Sentry Diff
ec4dc33 1219.19 ms 1250.82 ms 31.62 ms

App size

Revision Plain With Sentry Diff
ec4dc33 24.14 KiB 1.02 MiB 1017.43 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • .github/file-filters.yml

@itaybre itaybre marked this pull request as ready for review December 8, 2025 19:14
@itaybre itaybre merged commit 80f98b4 into main Dec 8, 2025
210 of 212 checks passed
@itaybre itaybre deleted the itay/remove_sentryprivate branch December 8, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Delete deprecated SentryPrivate

3 participants