Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Dec 5, 2025

When we detect an ANR started, we store the event information in a JSON file so we can recover it if it is fatal.

We are applying the scope to the event before saving it, but there is some information that doesn't belong to the scope or might not be present, like:

  • Release
  • Environment
  • Dist

In those cases when the event didn't have it stored, on the next launch, we are applying the current options to the stored event before uploading.

Because of this, we might end up with wrong information on this kind of events.

It is worth checking if this also applies to watchdog terminations events too.

Fixes: #5529

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.057%. Comparing base (8f33ee8) to head (c0388ea).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6998       +/-   ##
=============================================
+ Coverage   85.019%   85.057%   +0.037%     
=============================================
  Files          453       453               
  Lines        27643     27653       +10     
  Branches     12136     12137        +1     
=============================================
+ Hits         23502     23521       +19     
+ Misses        4093      4086        -7     
+ Partials        48        46        -2     
Files with missing lines Coverage Δ
Sources/Sentry/SentryANRTrackingIntegration.m 96.376% <100.000%> (+0.164%) ⬆️

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f33ee8...c0388ea. Read the comment docs.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Dec 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1201.53 ms 1240.10 ms 38.57 ms
Size 24.14 KiB 1.02 MiB 1018.28 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e8da57d 1203.77 ms 1234.85 ms 31.08 ms
d0f70ce 1226.54 ms 1247.04 ms 20.50 ms
89e74bc 1197.06 ms 1228.73 ms 31.67 ms
8203ac0 1235.59 ms 1256.02 ms 20.43 ms
884b224 1233.41 ms 1259.50 ms 26.09 ms
229b7b7 1219.45 ms 1249.36 ms 29.91 ms
483cc24 1218.00 ms 1242.59 ms 24.59 ms
e5773c1 1235.10 ms 1264.15 ms 29.04 ms
870b081 1226.77 ms 1246.33 ms 19.56 ms
827b50c 1233.27 ms 1267.28 ms 34.01 ms

App size

Revision Plain With Sentry Diff
e8da57d 23.75 KiB 919.69 KiB 895.94 KiB
d0f70ce 23.75 KiB 913.09 KiB 889.34 KiB
89e74bc 23.75 KiB 969.78 KiB 946.03 KiB
8203ac0 23.75 KiB 959.44 KiB 935.69 KiB
884b224 23.75 KiB 879.60 KiB 855.86 KiB
229b7b7 24.15 KiB 1.01 MiB 1014.90 KiB
483cc24 24.14 KiB 1.01 MiB 1010.98 KiB
e5773c1 23.75 KiB 1.00 MiB 1005.08 KiB
870b081 23.75 KiB 974.89 KiB 951.15 KiB
827b50c 23.75 KiB 1.00 MiB 1005.07 KiB

Previous results on branch: itay/release_name

Startup times

Revision Plain With Sentry Diff
87e5a60 1189.04 ms 1211.96 ms 22.92 ms

App size

Revision Plain With Sentry Diff
87e5a60 24.14 KiB 1.02 MiB 1017.69 KiB

@itaybre itaybre marked this pull request as ready for review December 8, 2025 22:19
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itaybre itaybre merged commit 3b189e1 into main Dec 9, 2025
194 checks passed
@itaybre itaybre deleted the itay/release_name branch December 9, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release and App version information not matching in App Hang events.

3 participants