-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Open
Labels
Meta: Breakingbreaking changejavascriptPull requests that update javascript codePull requests that update javascript code
Milestone
Description
Right now, we have various implementations and type declarations for attributes, serialization/conversion, etc. Given that spans (v2), metrics and logs all accept the same attributes, we should unify the respective declarations and the logic. This probably saves some bundle size for multi-product users.
Fully unifying attribute typing and serialization is a breaking change because:
- logs and metrics currently stringify array values
- stringification is not handled perfectly well and we could extract more information from obscure values:
- circular objects /h/t @s1gr1d for bringing up!)
undefined/nullvalues- objects throwing in
toJSONbut having atoString - => All of these cases can be improved but are breaking changes in terms of values
Actually removing duplicated logic between logs, metrics and span attributes is not part of this issue and should be addressed in #18159, #18161, #18160 directly (i.e. before the next major).
chargome
Metadata
Metadata
Assignees
Labels
Meta: Breakingbreaking changejavascriptPull requests that update javascript codePull requests that update javascript code