Skip to content

Commit 70baeb0

Browse files
specify telemetry types for attributes
1 parent ccfeaad commit 70baeb0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ What's the concrete advice when writing a new integration?
122122

123123
1. Are you supporting a product feature? Then ensure that product expectations are clearly documented in https://develop.sentry.dev/sdk/telemetry/traces/modules/.
124124

125-
2. Confirm that all attributes are defined in https://github.com/getsentry/sentry-conventions.
125+
2. Confirm that all span, breadcrumb, log or metric attributes are defined in https://github.com/getsentry/sentry-conventions.
126126

127127
3. Ensure that the **semantics** of the attribute are clear. If the attribute is not uniquely defined, do not add it.
128128
- For instance, do not attach a request model to an agent invocation span. On the other hand, a default request model can be well-defined.

0 commit comments

Comments
 (0)