feat(preprod): add basic base build info to build details api (EME-679) (#105145)

Adds base_build_info `build_details/` api response. This is needed to
support upcoming frontend changes to the size analysis build details
page build metadata table.

Author: cameroncooke

src/sentry/preprod/api/models/project_preprod_build_details_models.py

@@ -132,6 +132,7 @@ class BuildDetailsApiResponse(BaseModel):
     size_info: SizeInfo | None = None
     posted_status_checks: PostedStatusChecks | None = None
     base_artifact_id: str | None = None
+    base_build_info: BuildDetailsAppInfo | None = None
 
 
 def platform_from_artifact_type(artifact_type: PreprodArtifact.ArtifactType) -> Platform:
@@ -146,6 +147,53 @@ def platform_from_artifact_type(artifact_type: PreprodArtifact.ArtifactType) ->
             raise ValueError(f"Unknown artifact type: {artifact_type}")
 
 
+def create_build_details_app_info(artifact: PreprodArtifact) -> BuildDetailsAppInfo:
+    """Factory function to create BuildDetailsAppInfo from a PreprodArtifact."""
+    platform = None
+    # artifact_type can be null before preprocessing has completed
+    if artifact.artifact_type is not None:
+        platform = platform_from_artifact_type(artifact.artifact_type)
+
+    apple_app_info = None
+    if platform == Platform.IOS or platform == Platform.MACOS:
+        legacy_missing_dsym_binaries = (
+            artifact.extras.get("missing_dsym_binaries", []) if artifact.extras else []
+        )
+        has_missing_dsym_binaries = (
+            artifact.extras.get("has_missing_dsym_binaries", False)
+            or len(legacy_missing_dsym_binaries) > 0
+            if artifact.extras
+            else False
+        )
+        apple_app_info = AppleAppInfo(has_missing_dsym_binaries=has_missing_dsym_binaries)
+
+    android_app_info = None
+    if platform == Platform.ANDROID:
+        android_app_info = AndroidAppInfo(
+            has_proguard_mapping=(
+                artifact.extras.get("has_proguard_mapping", True) if artifact.extras else True
+            )
+        )
+
+    return BuildDetailsAppInfo(
+        app_id=artifact.app_id,
+        name=artifact.app_name,
+        version=artifact.build_version,
+        build_number=artifact.build_number,
+        date_added=(artifact.date_added.isoformat() if artifact.date_added else None),
+        date_built=(artifact.date_built.isoformat() if artifact.date_built else None),
+        artifact_type=artifact.artifact_type,
+        platform=platform,
+        is_installable=is_installable_artifact(artifact),
+        build_configuration=(
+            artifact.build_configuration.name if artifact.build_configuration else None
+        ),
+        app_icon_id=artifact.app_icon_id,
+        apple_app_info=apple_app_info,
+        android_app_info=android_app_info,
+    )
+
+
 def to_size_info(
     size_metrics: list[PreprodArtifactSizeMetrics],
     base_size_metrics: list[PreprodArtifactSizeMetrics] | None = None,
@@ -219,62 +267,18 @@ def transform_preprod_artifact_to_build_details(
 
     base_size_metrics_list: list[PreprodArtifactSizeMetrics] = []
     base_artifact = artifact.get_base_artifact_for_commit().first()
+    base_build_info = None
     if base_artifact:
         base_size_metrics_qs = PreprodArtifactSizeMetrics.objects.filter(
             preprod_artifact=base_artifact,
             state=PreprodArtifactSizeMetrics.SizeAnalysisState.COMPLETED,
         )
         base_size_metrics_list = list(base_size_metrics_qs)
+        base_build_info = create_build_details_app_info(base_artifact)
 
     size_info = to_size_info(size_metrics_list, base_size_metrics_list)
 
-    platform = None
-    # artifact_type can be null before preprocessing has completed
-    if artifact.artifact_type is not None:
-        platform = platform_from_artifact_type(artifact.artifact_type)
-
-    apple_app_info = None
-    if platform == Platform.IOS or platform == Platform.MACOS:
-        legacy_missing_dsym_binaries = (
-            artifact.extras.get("missing_dsym_binaries", []) if artifact.extras else []
-        )
-        has_missing_dsym_binaries = (
-            artifact.extras.get("has_missing_dsym_binaries", False)
-            or len(legacy_missing_dsym_binaries) > 0
-            if artifact.extras
-            else False
-        )
-        apple_app_info = AppleAppInfo(has_missing_dsym_binaries=has_missing_dsym_binaries)
-
-    android_app_info = None
-    if platform == Platform.ANDROID:
-        android_app_info = AndroidAppInfo(
-            has_proguard_mapping=(
-                artifact.extras.get("has_proguard_mapping", True) if artifact.extras else True
-            )
-        )
-
-    app_info = BuildDetailsAppInfo(
-        app_id=artifact.app_id,
-        name=artifact.app_name,
-        version=artifact.build_version,
-        build_number=artifact.build_number,
-        date_added=(artifact.date_added.isoformat() if artifact.date_added else None),
-        date_built=(artifact.date_built.isoformat() if artifact.date_built else None),
-        artifact_type=artifact.artifact_type,
-        platform=(
-            platform_from_artifact_type(artifact.artifact_type)
-            if artifact.artifact_type is not None
-            else None
-        ),
-        is_installable=is_installable_artifact(artifact),
-        build_configuration=(
-            artifact.build_configuration.name if artifact.build_configuration else None
-        ),
-        app_icon_id=artifact.app_icon_id,
-        apple_app_info=apple_app_info,
-        android_app_info=android_app_info,
-    )
+    app_info = create_build_details_app_info(artifact)
 
     vcs_info = BuildDetailsVcsInfo(
         head_sha=(artifact.commit_comparison.head_sha if artifact.commit_comparison else None),
@@ -301,6 +305,7 @@ def transform_preprod_artifact_to_build_details(
         size_info=size_info,
         posted_status_checks=posted_status_checks,
         base_artifact_id=base_artifact.id if base_artifact else None,
+        base_build_info=base_build_info,
     )
 
 

tests/sentry/preprod/api/endpoints/test_project_preprod_build_details.py

@@ -452,3 +452,55 @@ def test_posted_status_checks_failure_with_invalid_error_type(self) -> None:
         assert resp_data["posted_status_checks"] is not None
         assert resp_data["posted_status_checks"]["size"]["success"] is False
         assert resp_data["posted_status_checks"]["size"]["error_type"] is None
+
+    def test_base_build_info_when_base_artifact_exists(self) -> None:
+        """Test that base_build_info is included when a base artifact exists."""
+        assert self.preprod_artifact.commit_comparison is not None
+        base_commit_comparison = self.create_commit_comparison(
+            organization=self.org,
+            head_sha=self.preprod_artifact.commit_comparison.base_sha,
+            base_sha="0000000000000000000000000000000000000000",
+        )
+        base_file = self.create_file(name="base_artifact.apk", type="application/octet-stream")
+        base_artifact = self.create_preprod_artifact(
+            project=self.project,
+            file_id=base_file.id,
+            artifact_type=self.preprod_artifact.artifact_type,
+            app_id=self.preprod_artifact.app_id,
+            app_name=self.preprod_artifact.app_name,
+            build_version="0.9.0",
+            build_number=41,
+            commit_comparison=base_commit_comparison,
+        )
+
+        url = self._get_url()
+        response = self.client.get(
+            url, format="json", HTTP_AUTHORIZATION=f"Bearer {self.api_token.token}"
+        )
+
+        assert response.status_code == 200
+        resp_data = response.json()
+        assert resp_data["base_artifact_id"] == str(base_artifact.id)
+        assert resp_data["base_build_info"] is not None
+        # base_build_info now returns full BuildDetailsAppInfo
+        assert resp_data["base_build_info"]["version"] == "0.9.0"
+        assert resp_data["base_build_info"]["build_number"] == 41
+        assert resp_data["base_build_info"]["app_id"] == base_artifact.app_id
+        assert resp_data["base_build_info"]["name"] == base_artifact.app_name
+        assert resp_data["base_build_info"]["artifact_type"] == base_artifact.artifact_type
+        assert "date_added" in resp_data["base_build_info"]
+        assert "date_built" in resp_data["base_build_info"]
+        assert "is_installable" in resp_data["base_build_info"]
+        assert "platform" in resp_data["base_build_info"]
+
+    def test_base_build_info_none_when_no_base_artifact(self) -> None:
+        """Test that base_build_info is None when no base artifact exists."""
+        url = self._get_url()
+        response = self.client.get(
+            url, format="json", HTTP_AUTHORIZATION=f"Bearer {self.api_token.token}"
+        )
+
+        assert response.status_code == 200
+        resp_data = response.json()
+        assert resp_data["base_artifact_id"] is None
+        assert resp_data["base_build_info"] is None