Skip to content

Commit 97cd8e4

Browse files
authored
feat(perf): Remove "New" badge from Queries view (#59117)
It's been more than a month since release! The feature is no longer "New", and importantly a lot of other actually _new_ features are coming out soon.
1 parent 8833e62 commit 97cd8e4

File tree

5 files changed

+3
-27
lines changed

5 files changed

+3
-27
lines changed

static/app/components/sidebar/index.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ import {useLocation} from 'sentry/utils/useLocation';
4747
import useMedia from 'sentry/utils/useMedia';
4848
import useProjects from 'sentry/utils/useProjects';
4949
import {RELEASE_LEVEL as WEBVITALS_RELEASE_LEVEL} from 'sentry/views/performance/browser/webVitals/settings';
50-
import {RELEASE_LEVEL} from 'sentry/views/performance/database/settings';
5150

5251
import {ProfilingOnboardingSidebar} from '../profiling/ProfilingOnboarding/profilingOnboardingSidebar';
5352

@@ -239,9 +238,6 @@ function Sidebar({location, organization}: Props) {
239238
>
240239
<SidebarItem
241240
{...sidebarItemProps}
242-
isAlpha={RELEASE_LEVEL === 'alpha'}
243-
isBeta={RELEASE_LEVEL === 'beta'}
244-
isNew={RELEASE_LEVEL === 'new'}
245241
label={
246242
<GuideAnchor target="performance-database">
247243
{t('Queries')}

static/app/views/performance/database/databaseLandingPage.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import styled from '@emotion/styled';
22

33
import Alert from 'sentry/components/alert';
44
import Breadcrumbs from 'sentry/components/breadcrumbs';
5-
import FeatureBadge from 'sentry/components/featureBadge';
65
import FeedbackWidget from 'sentry/components/feedback/widget/feedbackWidget';
76
import * as Layout from 'sentry/components/layouts/thirds';
87
import {DatePageFilter} from 'sentry/components/organizations/datePageFilter';
@@ -15,7 +14,6 @@ import useOrganization from 'sentry/utils/useOrganization';
1514
import {normalizeUrl} from 'sentry/utils/withDomainRequired';
1615
import {ModulePageProviders} from 'sentry/views/performance/database/modulePageProviders';
1716
import {NoDataMessage} from 'sentry/views/performance/database/noDataMessage';
18-
import {RELEASE_LEVEL} from 'sentry/views/performance/database/settings';
1917
import {ModuleName, SpanMetricsField} from 'sentry/views/starfish/types';
2018
import {QueryParameterNames} from 'sentry/views/starfish/views/queryParameters';
2119
import {ActionSelector} from 'sentry/views/starfish/views/spans/selectors/actionSelector';
@@ -49,10 +47,7 @@ function DatabaseLandingPage() {
4947
]}
5048
/>
5149

52-
<Layout.Title>
53-
{t('Queries')}
54-
<FeatureBadge type={RELEASE_LEVEL} />
55-
</Layout.Title>
50+
<Layout.Title>{t('Queries')}</Layout.Title>
5651
</Layout.HeaderContent>
5752
</Layout.Header>
5853

static/app/views/performance/database/databaseSpanSummaryPage.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import styled from '@emotion/styled';
33
import {Location} from 'history';
44

55
import Breadcrumbs from 'sentry/components/breadcrumbs';
6-
import FeatureBadge from 'sentry/components/featureBadge';
76
import FeedbackWidget from 'sentry/components/feedback/widget/feedbackWidget';
87
import * as Layout from 'sentry/components/layouts/thirds';
98
import {DatePageFilter} from 'sentry/components/organizations/datePageFilter';
@@ -18,7 +17,6 @@ import {useLocation} from 'sentry/utils/useLocation';
1817
import useOrganization from 'sentry/utils/useOrganization';
1918
import {normalizeUrl} from 'sentry/utils/withDomainRequired';
2019
import {ModulePageProviders} from 'sentry/views/performance/database/modulePageProviders';
21-
import {RELEASE_LEVEL} from 'sentry/views/performance/database/settings';
2220
import {AVG_COLOR, THROUGHPUT_COLOR} from 'sentry/views/starfish/colours';
2321
import Chart, {useSynchronizeCharts} from 'sentry/views/starfish/components/chart';
2422
import ChartPanel from 'sentry/views/starfish/components/chartPanel';
@@ -139,10 +137,7 @@ function SpanSummaryPage({params}: Props) {
139137
},
140138
]}
141139
/>
142-
<Layout.Title>
143-
{t('Query Summary')}
144-
<FeatureBadge type={RELEASE_LEVEL} />
145-
</Layout.Title>
140+
<Layout.Title>{t('Query Summary')}</Layout.Title>
146141
</Layout.HeaderContent>
147142
</Layout.Header>
148143

static/app/views/performance/database/settings.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
import {BadgeType} from 'sentry/components/featureBadge';
2-
3-
export const RELEASE_LEVEL: BadgeType = 'new';
4-
51
export const MIN_SDK_VERSION_BY_PLATFORM: {[platform: string]: string} = {
62
'sentry.python': '1.29.2',
73
'sentry.javascript': '7.63.0',

static/app/views/performance/landing/widgets/components/widgetHeader.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,17 @@ import QuestionTooltip from 'sentry/components/questionTooltip';
66
import TextOverflow from 'sentry/components/textOverflow';
77
import {space} from 'sentry/styles/space';
88
import {MEPTag} from 'sentry/utils/performance/contexts/metricsEnhancedPerformanceDataContext';
9-
import {RELEASE_LEVEL} from 'sentry/views/performance/database/settings';
109

1110
import {
1211
GenericPerformanceWidgetProps,
1312
WidgetDataConstraint,
1413
WidgetDataProps,
1514
} from '../types';
16-
import {PerformanceWidgetSetting} from '../widgetDefinitions';
1715

1816
export function WidgetHeader<T extends WidgetDataConstraint>(
1917
props: GenericPerformanceWidgetProps<T> & WidgetDataProps<T>
2018
) {
21-
const {title, titleTooltip, Subtitle, HeaderActions, InteractiveTitle, chartSetting} =
22-
props;
23-
const isStarfishDBWidget =
24-
chartSetting === PerformanceWidgetSetting.MOST_TIME_SPENT_DB_QUERIES;
19+
const {title, titleTooltip, Subtitle, HeaderActions, InteractiveTitle} = props;
2520
return (
2621
<WidgetHeaderContainer>
2722
<TitleContainer>
@@ -31,7 +26,6 @@ export function WidgetHeader<T extends WidgetDataConstraint>(
3126
) : (
3227
<TextOverflow>{title}</TextOverflow>
3328
)}
34-
{isStarfishDBWidget && <FeatureBadge type={RELEASE_LEVEL} />}
3529
<MEPTag />
3630
{titleTooltip && (
3731
<QuestionTooltip position="top" size="sm" title={titleTooltip} />

0 commit comments

Comments
 (0)