Skip to content

Commit cae1684

Browse files
ref: remove noop objects = BaseManager() assignments (#59101)
the default `Model` gives us this for free -- this is needed to upgrade django-stubs + mypy
1 parent ebcdf20 commit cae1684

File tree

6 files changed

+5
-48
lines changed

6 files changed

+5
-48
lines changed

src/sentry/models/groupbookmark.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,7 @@
33
from django.utils import timezone
44

55
from sentry.backup.scopes import RelocationScope
6-
from sentry.db.models import (
7-
BaseManager,
8-
FlexibleForeignKey,
9-
Model,
10-
region_silo_only_model,
11-
sane_repr,
12-
)
6+
from sentry.db.models import FlexibleForeignKey, Model, region_silo_only_model, sane_repr
137
from sentry.db.models.fields.hybrid_cloud_foreign_key import HybridCloudForeignKey
148

159

@@ -28,8 +22,6 @@ class GroupBookmark(Model):
2822
user_id = HybridCloudForeignKey(settings.AUTH_USER_MODEL, on_delete="CASCADE")
2923
date_added = models.DateTimeField(default=timezone.now, null=True)
3024

31-
objects = BaseManager()
32-
3325
class Meta:
3426
app_label = "sentry"
3527
db_table = "sentry_groupbookmark"

src/sentry/models/groupemailthread.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,7 @@
22
from django.utils import timezone
33

44
from sentry.backup.scopes import RelocationScope
5-
from sentry.db.models import (
6-
BaseManager,
7-
FlexibleForeignKey,
8-
Model,
9-
region_silo_only_model,
10-
sane_repr,
11-
)
5+
from sentry.db.models import FlexibleForeignKey, Model, region_silo_only_model, sane_repr
126

137

148
@region_silo_only_model
@@ -28,8 +22,6 @@ class GroupEmailThread(Model):
2822
msgid = models.CharField(max_length=100)
2923
date = models.DateTimeField(default=timezone.now, db_index=True)
3024

31-
objects = BaseManager()
32-
3325
class Meta:
3426
app_label = "sentry"
3527
db_table = "sentry_groupemailthread"

src/sentry/models/groupshare.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,7 @@
55
from django.utils import timezone
66

77
from sentry.backup.scopes import RelocationScope
8-
from sentry.db.models import (
9-
BaseManager,
10-
FlexibleForeignKey,
11-
Model,
12-
region_silo_only_model,
13-
sane_repr,
14-
)
8+
from sentry.db.models import FlexibleForeignKey, Model, region_silo_only_model, sane_repr
159
from sentry.db.models.fields.hybrid_cloud_foreign_key import HybridCloudForeignKey
1610

1711

@@ -34,8 +28,6 @@ class GroupShare(Model):
3428
user_id = HybridCloudForeignKey(settings.AUTH_USER_MODEL, on_delete="CASCADE", null=True)
3529
date_added = models.DateTimeField(default=timezone.now)
3630

37-
objects = BaseManager()
38-
3931
class Meta:
4032
app_label = "sentry"
4133
db_table = "sentry_groupshare"

src/sentry/models/projectbookmark.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,7 @@
33
from django.utils import timezone
44

55
from sentry.backup.scopes import RelocationScope
6-
from sentry.db.models import (
7-
BaseManager,
8-
FlexibleForeignKey,
9-
Model,
10-
region_silo_only_model,
11-
sane_repr,
12-
)
6+
from sentry.db.models import FlexibleForeignKey, Model, region_silo_only_model, sane_repr
137
from sentry.db.models.fields.hybrid_cloud_foreign_key import HybridCloudForeignKey
148
from sentry.models.project import Project
159

@@ -26,8 +20,6 @@ class ProjectBookmark(Model):
2620
user_id = HybridCloudForeignKey(settings.AUTH_USER_MODEL, on_delete="CASCADE")
2721
date_added = models.DateTimeField(default=timezone.now, null=True)
2822

29-
objects = BaseManager()
30-
3123
class Meta:
3224
app_label = "sentry"
3325
db_table = "sentry_projectbookmark"

src/sentry/models/rawevent.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
from sentry.backup.scopes import RelocationScope
55
from sentry.db.models import FlexibleForeignKey, Model, NodeField, region_silo_only_model, sane_repr
6-
from sentry.db.models.manager import BaseManager
76
from sentry.utils.canonical import CanonicalKeyView
87

98

@@ -22,8 +21,6 @@ class RawEvent(Model):
2221
blank=True, null=True, ref_func=ref_func, ref_version=1, wrapper=CanonicalKeyView
2322
)
2423

25-
objects = BaseManager()
26-
2724
class Meta:
2825
app_label = "sentry"
2926
db_table = "sentry_rawevent"

src/sentry/models/reprocessingreport.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,7 @@
22
from django.utils import timezone
33

44
from sentry.backup.scopes import RelocationScope
5-
from sentry.db.models import (
6-
BaseManager,
7-
FlexibleForeignKey,
8-
Model,
9-
region_silo_only_model,
10-
sane_repr,
11-
)
5+
from sentry.db.models import FlexibleForeignKey, Model, region_silo_only_model, sane_repr
126

137

148
@region_silo_only_model
@@ -19,8 +13,6 @@ class ReprocessingReport(Model):
1913
event_id = models.CharField(max_length=32, null=True)
2014
datetime = models.DateTimeField(default=timezone.now)
2115

22-
objects = BaseManager()
23-
2416
class Meta:
2517
app_label = "sentry"
2618
db_table = "sentry_reprocessingreport"

0 commit comments

Comments
 (0)