Make but tests work in non-legacy mode and the capability to CI

This allows us to validate the non-legacy mode as well.

Author: Byron

.github/workflows/push.yaml

@@ -184,6 +184,8 @@ jobs:
         env:
           GITBUTLER_TESTS_NO_CLEANUP: '1'
         name: cargo test
+      # It's intentional to use 'name equals run-script' so it's easy to re-run locally on failure.
+      - run: cargo test -p but --no-default-features
 
   rust-test-tauri:
     needs: changes

Cargo.lock

@@ -19,6 +19,3 @@ doctest = false
 but.workspace = true
 clap.workspace = true
 anyhow.workspace = true
-
-[dev-dependencies]
-snapbox.workspace = true

crates/but-clap/Cargo.toml

@@ -7,6 +7,7 @@ fn clap() {
 }
 
 mod push {
+    #[cfg(feature = "legacy")]
     mod get_gerrit_flags {
         use crate::args::push::Command as Args;
         use crate::command::legacy::push::get_gerrit_flags;

crates/but/src/args/tests.rs

@@ -1,5 +1,3 @@
-use snapbox::str;
-
 use crate::utils::Sandbox;
 
 #[test]
@@ -13,26 +11,31 @@ fn json_flag_can_be_placed_before_or_after_subcommand() -> anyhow::Result<()> {
 
     env.but("completions --help --json").assert().success();
 
-    // Test with actual commands that need a repo (they'll fail but should accept the flag)
-    // Before subcommand
-    env.but("--json status")
-        .env_remove("BUT_OUTPUT_FORMAT")
-        .assert()
-        .failure()
-        .stderr_eq(str![[r#"
+    // Without legacy
+    #[cfg(feature = "legacy")]
+    {
+        use snapbox::str;
+        // Test with actual commands that need a repo (they'll fail but should accept the flag)
+        // Before subcommand
+        env.but("--json status")
+            .env_remove("BUT_OUTPUT_FORMAT")
+            .assert()
+            .failure()
+            .stderr_eq(str![[r#"
 Error: Could not find a git repository in '.' or in any of its parents[..]
 
 "#]]);
 
-    // After subcommand
-    env.but("status --json")
-        .env_remove("BUT_OUTPUT_FORMAT")
-        .assert()
-        .failure()
-        .stderr_eq(str![[r#"
+        // After subcommand
+        env.but("status --json")
+            .env_remove("BUT_OUTPUT_FORMAT")
+            .assert()
+            .failure()
+            .stderr_eq(str![[r#"
 Error: Could not find a git repository in '.' or in any of its parents[..]
 
 "#]]);
+    }
 
     Ok(())
 }

crates/but/tests/but/command/format.rs

@@ -1,5 +1,16 @@
 use crate::utils::Sandbox;
 
+#[cfg(not(feature = "legacy"))]
+#[test]
+fn looks_good_and_can_be_invoked_in_various_ways_non_legacy() -> anyhow::Result<()> {
+    let env = Sandbox::empty()?;
+    env.but(None).assert().success().stdout_eq(snapbox::file![
+        "snapshots/help/no-arg-no-legacy.stdout.term.svg"
+    ]);
+    Ok(())
+}
+
+#[cfg(feature = "legacy")]
 #[test]
 fn looks_good_and_can_be_invoked_in_various_ways() -> anyhow::Result<()> {
     let env = Sandbox::empty()?;
@@ -21,6 +32,7 @@ fn looks_good_and_can_be_invoked_in_various_ways() -> anyhow::Result<()> {
     Ok(())
 }
 
+#[cfg(feature = "legacy")]
 #[test]
 fn rub_looks_good() -> anyhow::Result<()> {
     let env = Sandbox::empty()?;

crates/but/tests/but/command/help.rs

@@ -1,8 +1,12 @@
 //! Put command-specific tests here. They should be focused on what's important for each command.
 //! Ideally they *show* the initial state, and the *post* state, to validate the commands actually do what they claim.
+#[cfg(feature = "legacy")]
 mod branch;
+#[cfg(feature = "legacy")]
 mod commit;
 mod format;
 mod help;
+#[cfg(feature = "legacy")]
 mod rub;
+#[cfg(feature = "legacy")]
 mod status;

crates/but/tests/but/command/mod.rs

@@ -1,4 +1,7 @@
 mod command;
+// TODO: Id tests can be on integration level, but shouldn't involve the CLI
+#[cfg(feature = "legacy")]
 mod id;
+#[cfg(feature = "legacy")]
 mod journey;
 pub mod utils;