Skip to content

Commit bf5fbc3

Browse files
committed
Fix "if" condition evaluating before the prerequisite filter had run
It seems like unless there is a dependency through a “needs” tag, the “if” statements will be evaluated immediately - causing them to not see the filter output from the `changes` step resulting in them evaluating to false
1 parent 4314abc commit bf5fbc3

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

.github/workflows/push.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ jobs:
8282
./scripts/generate-ts-definitions-from-rust.sh
8383
8484
lint-node:
85+
needs: changes
8586
if: ${{ needs.changes.outputs.node == 'true' || needs.changes.outputs.rust == 'true' }}
8687
runs-on: ubuntu-latest
8788
steps:
@@ -92,6 +93,7 @@ jobs:
9293
- run: pnpm lint
9394

9495
check-node:
96+
needs: changes
9597
if: ${{ needs.changes.outputs.node == 'true' || needs.changes.outputs.rust == 'true' }}
9698
runs-on: ubuntu-latest
9799
steps:
@@ -102,6 +104,7 @@ jobs:
102104
- run: pnpm check
103105

104106
unittest-node:
107+
needs: changes
105108
if: ${{ needs.changes.outputs.node == 'true' }}
106109
runs-on: ubuntu-latest
107110
steps:

0 commit comments

Comments
 (0)