Make generate-ts easier to handle

Ideally, it's clear why tests fail and how to fix them.

- add a cache
- focus the test-runs to only the crates that harbor ts type definitions
- remove CI dependencies as the dependents hang if there was no Rust change, which
  causes the definitions job to not run.

Author: Byron

.github/workflows/push.yaml

@@ -64,19 +64,24 @@ jobs:
     needs: changes
     if: ${{ needs.changes.outputs.node == 'true' || needs.changes.outputs.rust == 'true' }}
     runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/gitbutlerapp/ci-base-image:latest
     env:
       CARGO_TERM_COLOR: always
     steps:
       - uses: actions/checkout@v6
         with:
           persist-credentials: false
+      - name: Rust Cache
+        uses: Swatinem/rust-cache@v2.8.1
+        with:
+          shared-key: ts-def-gen
+          save-if: ${{ github.ref == 'refs/heads/master' }}
+      # Node is needed for the formatting of typescript files.
       - uses: ./.github/actions/init-env-node
-      - run: pnpm generate-ts-definitions
+      - run: |
+          sudo apt install libdbus-1-dev pkg-config
+          ./scripts/generate-ts-definitions-from-rust.sh
 
   lint-node:
-    needs: generate-ts-definitions
     if: ${{ needs.changes.outputs.node == 'true' || needs.changes.outputs.rust == 'true' }}
     runs-on: ubuntu-latest
     steps:
@@ -87,7 +92,6 @@ jobs:
       - run: pnpm lint
 
   check-node:
-    needs: generate-ts-definitions
     if: ${{ needs.changes.outputs.node == 'true' || needs.changes.outputs.rust == 'true' }}
     runs-on: ubuntu-latest
     steps:
@@ -98,7 +102,6 @@ jobs:
       - run: pnpm check
 
   unittest-node:
-    needs: generate-ts-definitions
     if: ${{ needs.changes.outputs.node == 'true' }}
     runs-on: ubuntu-latest
     steps:

README.md

@@ -137,3 +137,4 @@ at the [DEVELOPMENT.md](DEVELOPMENT.md) file.
 <a href="https://github.com/gitbutlerapp/gitbutler/graphs/contributors">
   <img src="https://contrib.rocks/image?repo=gitbutlerapp/gitbutler" />
 </a>
+hi

package.json

@@ -38,7 +38,7 @@
 		"rustfmt": "cargo +nightly fmt -- --config-path rustfmt-nightly.toml",
 		"isgood": "pnpm check && pnpm lint",
 		"begood": "pnpm format && pnpm fix",
-		"generate-ts-definitions": "pnpm --filter @gitbutler/core generate-ts"
+		"generate-ts-definitions": "scripts/generate-ts-definitions-from-rust.sh"
 	},
 	"devDependencies": {
 		"@eslint/js": "9.33.0",

packages/core/package.json

@@ -7,7 +7,6 @@
 		"check": "tsc --noEmit",
 		"build": "tsc -p tsconfig.json",
 		"format": "prettier --write .",
-		"generate-ts": "TS_RS_EXPORT_DIR=\"$PNPM_SCRIPT_SRC_DIR/src/generated\" cargo test --features export-ts export_bindings && pnpm format",
 		"package": "tsc -p tsconfig.json"
 	},
 	"exports": {

scripts/generate-ts-definitions-from-rust.sh

@@ -0,0 +1,19 @@
+#!/bin/bash
+
+set -eu -o pipefail
+
+git rev-parse --show-toplevel
+git_root="$(git rev-parse --show-toplevel 2>/dev/null)"
+cd "$git_root"
+
+CRATE_ARGS="$(git grep "export-ts" | awk -F: '{ split($1, parts, "/"); if (length(parts) >= 3) { if (parts[1] == "crates") { crate = parts[2] } else { next } if (!seen[crate]++) print "-p " crate } }')"
+
+# NOTE: export_bindings is generated by the TS proc-macro, and doesn't actually exist.
+TS_RS_EXPORT_DIR="$PWD/packages/core/src/generated" cargo test ${CRATE_ARGS} --features export-ts export_bindings
+pnpm format
+
+if ! git diff --quiet; then
+  git status
+  echo "There are changed TS bindings. This error will go away with `git add .`, and on CI when the changes are committed."
+  exit 2
+fi