Skip to content

Commit 1bb2d2c

Browse files
committed
Fix the URL of the "This branch is now known as <name>" links
Most recently seen in gitgitgadget/git#1405 (comment), the URLs pointing to the maintainer's branches reflecting the current PR are bogus: Instead of the correct https://github.com/gitster/git/commits/pw/rebase-no-reflog-action, the forward slash between `gitster` and `git` is replaced with a `.`. This bug was introduced some time between February 10th 2022 (gitgitgadget/git#1140 (comment)) and February 15t 2022 (gitgitgadget/git#1142 (comment)). We could now simply replace the `.` by a `/`, but that would introduce _another_ problem: as a lottery factor exercise, Git is currently maintained by an interim maintainer and therefore the maintainer branches in https://github.com/gitster/git aren't updated at all. Let's side-step that problem completely by using URLs pointing to the branches that are mirrored into https://github.com/gitgitgadget/git (which are currently mirrored from https://github.com/ttaylorr/git, i.e. from the interim maintainer's personal fork). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 parent 65fd9e2 commit 1bb2d2c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/ci-helper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ export class CIHelper {
317317

318318
// Identify branch in maintainer repo
319319
const maintainerBranch = `refs/remotes/${this.config.repo.maintainerBranch}/`;
320-
const maintainerRepo = `${this.config.repo.maintainerBranch}.${this.config.repo.name}`;
320+
const maintainerRepo = `${this.config.repo.owner}/${this.config.repo.name}`;
321321

322322
let gitsterBranch: string | undefined =
323323
await git(["for-each-ref", `--points-at=${tipCommitInGitGit}`,

0 commit comments

Comments
 (0)