Skip to content

Commit 1c83bb9

Browse files
committed
Change the network error to a warning
1 parent 0af7a04 commit 1c83bb9

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

src/gren.js

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ var defaults = {
2424
prerelease: false,
2525
dateZero: new Date(0),
2626
override: false,
27-
ignoredLabels: false, // || array of labels
27+
ignoreLabels: false, // || array of labels
2828
ignoreIssuesWith: false, // || array of labels
2929
template: templateConfig
3030
};
@@ -318,7 +318,7 @@ function templateLabels(gren, issue) {
318318

319319
return issue.labels
320320
.filter(function(label) {
321-
return gren.options.ignoredLabels.indexOf(label.name) === -1;
321+
return gren.options.ignoreLabels.indexOf(label.name) === -1;
322322
})
323323
.map(function(label) {
324324
return template.generate({
@@ -518,13 +518,13 @@ function getCommitBlocks(gren, releaseRanges) {
518518
* @since 0.6.0
519519
* @private
520520
*
521-
* @param {Array} ignoredLabels The labels to ignore
521+
* @param {Array} ignoreLabels The labels to ignore
522522
* @param {Array} labels The labels to check
523523
*
524524
* @return {boolean} If the labels array contain any of the ignore ones
525525
*/
526-
function compareIssueLabels(ignoredLabels, labels) {
527-
return ignoredLabels
526+
function compareIssueLabels(ignoreLabels, labels) {
527+
return ignoreLabels
528528
.reduce(function(carry, ignoredLabel) {
529529
return carry && labels.map(function(label) {
530530
return label.name;
@@ -761,12 +761,10 @@ function generateOptions(options) {
761761
* @return {Promise}
762762
*/
763763
function hasNetwork() {
764-
return new Promise(function(resolve, reject) {
764+
return new Promise(function(resolve) {
765765
connectivity(function(isOnline) {
766766
if (!isOnline) {
767-
reject(chalk.red('You need to have network connectivity'));
768-
769-
return;
767+
console.warn(chalk.yellow('WARNING: Looks like you don\'t have network connectivity!'));
770768
}
771769

772770
resolve();
@@ -785,7 +783,7 @@ function hasNetwork() {
785783
function GithubReleaseNotes(options) {
786784
this.options = ObjectAssign({}, defaults, configFile, options || utils.getBashOptions(process.argv));
787785
this.options.tags = utils.convertStringToArray(this.options.tags);
788-
this.options.ignoredLabels = utils.convertStringToArray(this.options.ignoredLabels);
786+
this.options.ignoreLabels = utils.convertStringToArray(this.options.ignoreLabels);
789787
this.options.ignoreIssuesWith = utils.convertStringToArray(this.options.ignoreIssuesWith);
790788
this.repo = null;
791789
this.issues = null;

src/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function task(gren, taskName) {
5151
* @param {GithubReleaseNotes} gren
5252
*/
5353
function clearTasks(gren) {
54-
if (!gren.tasks.length) {
54+
if (!Object.keys(gren.tasks.length)) {
5555
return;
5656
}
5757

0 commit comments

Comments
 (0)