Skip to content

Commit 6734707

Browse files
authored
Fix failing test (#281)
* Fix failing specs * Fix tests that require network Target tags should be listed in the first 10. `gren.options.dataSource` seems required in `_getReleaseBlocks()`
1 parent 62c9289 commit 6734707

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

test/Gren.spec.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -544,9 +544,10 @@ describe('Gren', () => {
544544

545545
const receivedObject = gren._transformTagsIntoReleaseObjects([tag]);
546546

547-
assert.equals(tag.date, receivedObject.date);
548-
assert.equals(tag.releaseId, receivedObject.id);
549-
assert.equals(tag.name, receivedObject.name);
547+
assert.equal(1, receivedObject.length)
548+
assert.equal(tag.date, receivedObject[0].date);
549+
assert.equal(tag.releaseId, receivedObject[0].id);
550+
assert.equal(tag.tag.name, receivedObject[0].name);
550551
});
551552
});
552553

@@ -609,11 +610,11 @@ describe('Gren', () => {
609610
describe('with tags=all', () => {
610611
describe('with ignoreTagsWith', () => {
611612
it('should ignore the specific tag', done => {
612-
gren.options.ignoreTagsWith = ['11'];
613+
gren.options.ignoreTagsWith = ['16'];
613614
gren.options.tags = ['all'];
614615
gren._getLastTags()
615616
.then(tags => {
616-
assert.notInclude(tags.map(({ name }) => name), '0.11.0', 'The ignored tag is not present');
617+
assert.notInclude(tags.map(({ name }) => name), '0.16.0', 'The ignored tag is not present');
617618
done();
618619
})
619620
.catch(err => done(err));
@@ -624,7 +625,8 @@ describe('Gren', () => {
624625

625626
describe('_getReleaseBlocks', () => {
626627
it('more than one tag', done => {
627-
gren.options.tags = ['0.12.0', '0.11.0'];
628+
gren.options.tags = ['0.17.2', '0.17.1'];
629+
gren.options.dataSource = "commits";
628630
gren._getReleaseBlocks()
629631
.then(releaseBlocks => {
630632
assert.isArray(releaseBlocks, 'The releaseBlocks is an Array');
@@ -637,7 +639,8 @@ describe('Gren', () => {
637639
}).timeout(10000);
638640

639641
it('just one tag', done => {
640-
gren.options.tags = ['0.11.0'];
642+
gren.options.tags = ['0.17.2'];
643+
gren.options.dataSource = "commits";
641644
gren._getReleaseBlocks()
642645
.then(releaseBlocks => {
643646
assert.isArray(releaseBlocks, 'The releaseBlocks is an Array');

0 commit comments

Comments
 (0)