Added RULE-17-2

Author: s-samadi

c/misra/src/rules/RULE-17-2/RecursiveFunctionCondition.ql

@@ -0,0 +1,27 @@
+/**
+ * @id c/misra/recursive-function-condition
+ * @name RULE-17-2: Functions shall not call themselves, either directly or indirectly
+ * @description Recursive function may cause memory and system failure issues.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity error
+ * @tags external/misra/id/rule-17-2
+ *       maintainability
+ *       correctness
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.c.misra
+
+from FunctionCall call, string msg, FunctionCall fc
+where
+  not isExcluded(fc, Statements3Package::recursiveFunctionConditionQuery()) and
+  fc.getTarget() = call.getTarget() and
+  call.getTarget().calls*(call.getEnclosingFunction()) and
+  if fc.getTarget() = fc.getEnclosingFunction()
+  then msg = "This call directly invokes its containing function $@."
+  else
+    msg =
+      "The function " + fc.getEnclosingFunction() + " is indirectly recursive via this call to $@."
+select fc, msg, fc.getTarget(), fc.getTarget().getName()

c/misra/test/rules/RULE-17-2/RecursiveFunctionCondition.expected

@@ -0,0 +1,4 @@
+| test.c:8:3:8:4 | call to f3 | This call directly invokes its containing function $@. | test.c:7:6:7:7 | f3 | f3 |
+| test.c:11:3:11:4 | call to f3 | The function f6 is indirectly recursive via this call to $@. | test.c:7:6:7:7 | f3 | f3 |
+| test.c:15:3:15:4 | call to f2 | The function f5 is indirectly recursive via this call to $@. | test.c:17:6:17:7 | f2 | f2 |
+| test.c:18:3:18:4 | call to f5 | The function f2 is indirectly recursive via this call to $@. | test.c:14:6:14:7 | f5 | f5 |

c/misra/test/rules/RULE-17-2/RecursiveFunctionCondition.qlref

@@ -0,0 +1 @@
+rules/RULE-17-2/RecursiveFunctionCondition.ql

c/misra/test/rules/RULE-17-2/test.c

@@ -0,0 +1,19 @@
+void f1();
+void f2();
+void f4(int p1) { // COMPLIANT
+  f1();
+}
+
+void f3() {
+  f3(); // NON_COMPLIANT
+}
+void f6() {
+  f3(); // NON_COMPLIANT
+}
+
+void f5() {
+  f2(); // NON_COMPLIANT
+}
+void f2() {
+  f5(); // NON_COMPLIANT
+}