Apply review comments externallinkagearraywithoutexplicitsize

Author: knewbury01

cpp/common/src/codingstandards/cpp/rules/externallinkagearraywithoutexplicitsize/ExternalLinkageArrayWithoutExplicitSize.qll

@@ -1,7 +1,6 @@
 /**
  * Provides a library with a `problems` predicate for the following issue:
- * Introducing a function or object with external linkage outside of a header file can
- * cause developer confusion about its translation unit access semantics.
+ * Declaring an array with external linkage without its size being explicitly specified can disallow consistency and range checks on the array size and usage.
  */
 
 import cpp
@@ -21,9 +20,9 @@ query predicate problems(DeclarationEntry declEntry, string message) {
         "' with external linkage doesn't specify the size explicitly." and
     hasExternalLinkage(v) and
     not arrayType.hasArraySize() and
-    // Holds is if declEntry is an array variable declaration (not a definition)
+    // Holds if declEntry is an array variable declaration (not a definition)
     v.getADeclarationEntry() = declEntry and
     not declEntry.isDefinition() and
-    arrayType = v.getType().stripTopLevelSpecifiers()
+    arrayType = declEntry.getType().stripTopLevelSpecifiers()
   )
 }

cpp/common/test/rules/externallinkagearraywithoutexplicitsize/ExternalLinkageArrayWithoutExplicitSize.expected

@@ -1 +1,2 @@
 | test.cpp:19:14:19:15 | declaration of e1 | The declared array 'e1' with external linkage doesn't specify the size explicitly. |
+| test.hpp:2:13:2:26 | declaration of header_and_cpp | The declared array 'header_and_cpp' with external linkage doesn't specify the size explicitly. |

cpp/common/test/rules/externallinkagearraywithoutexplicitsize/test.cpp

@@ -24,6 +24,13 @@ struct s {
   int foo;
 
   // static data members have external linkage - but not currently detected in
-  // our external linkage lib - also FAMs are not in scope for this rule
-  static const int flexibleArrayMember[]; // COMPLIANT
-};
+  // our external linkage lib - also FAMs are expected to be detected
+  // specifically in RULE-18-7
+  static const int flexibleArrayMember[]; // NON_COMPLIANT[FALSE_NEGATIVE]
+  static int flexibleArrayMember2[];      // NON_COMPLIANT[FALSE_NEGATIVE]
+};
+
+// test.cpp
+#include "test.hpp"
+// definition associated with a declaration from test.hpp
+int header_and_cpp[1] = {1};

cpp/common/test/rules/externallinkagearraywithoutexplicitsize/test.hpp

@@ -0,0 +1,2 @@
+// test.hpp
+ extern int header_and_cpp[]; // NON_COMPLIANT