Merge pull request #1850 from hvitved/csharp/remove-ref-equal

semmle-qlci · web-flow · commit 00fe4734ac8b · 2019-09-01T09:31:50.000+01:00
Approved by calumgrant
diff --git a/csharp/extractor/Semmle.Extraction/Entities/Assembly.cs b/csharp/extractor/Semmle.Extraction/Entities/Assembly.cs
@@ -36,7 +36,7 @@ public override void Populate(TextWriter trapFile)
         }
 
         public override bool NeedsPopulation =>
-            assembly != Context.Compilation.Assembly || !Context.IsGlobalContext;
+            !Equals(assembly, Context.Compilation.Assembly) || !Context.IsGlobalContext;
 
         public override int GetHashCode() =>
             symbol == null ? 91187354 : symbol.GetHashCode();

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public override void Populate(TextWriter trapFile)`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`public override bool NeedsPopulation =>`
`39`		`- assembly != Context.Compilation.Assembly \|\| !Context.IsGlobalContext;`
	`39`	`+ !Equals(assembly, Context.Compilation.Assembly) \|\| !Context.IsGlobalContext;`
`40`	`40`
`41`	`41`	`public override int GetHashCode() =>`
`42`	`42`	`symbol == null ? 91187354 : symbol.GetHashCode();`