Apply suggestions from code review

jorgectf · tausbn · web-flow · commit 0216798cb958 · 2022-02-22T20:55:51.000+01:00
Co-authored-by: Taus &lt;tausbn@github.com&gt;
diff --git a/python/ql/src/experimental/semmle/python/libraries/Python_JWT.qll b/python/ql/src/experimental/semmle/python/libraries/Python_JWT.qll
@@ -33,9 +33,9 @@ private module Python_JWT {
 
     override DataFlow::Node getPayload() { result = this.getArg(0) }
 
-    override DataFlow::Node getKey() { result = verifyCall().getArg(1) }
+    override DataFlow::Node getKey() { result = this.verifyCall().getArg(1) }
 
-    override DataFlow::Node getAlgorithm() { result = verifyCall().getArg(2) }
+    override DataFlow::Node getAlgorithm() { result = this.verifyCall().getArg(2) }
 
     override string getAlgorithmString() {
       exists(StrConst str |
@@ -46,6 +46,6 @@ private module Python_JWT {
 
     override DataFlow::Node getOptions() { none() }
 
-    override predicate verifiesSignature() { exists(verifyCall()) }
+    override predicate verifiesSignature() { exists(this.verifyCall()) }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -33,9 +33,9 @@ private module Python_JWT {`
`33`	`33`
`34`	`34`	`override DataFlow::Node getPayload() { result = this.getArg(0) }`
`35`	`35`
`36`		`- override DataFlow::Node getKey() { result = verifyCall().getArg(1) }`
	`36`	`+ override DataFlow::Node getKey() { result = this.verifyCall().getArg(1) }`
`37`	`37`
`38`		`- override DataFlow::Node getAlgorithm() { result = verifyCall().getArg(2) }`
	`38`	`+ override DataFlow::Node getAlgorithm() { result = this.verifyCall().getArg(2) }`
`39`	`39`
`40`	`40`	`override string getAlgorithmString() {`
`41`	`41`	`exists(StrConst str \|`
`@@ -46,6 +46,6 @@ private module Python_JWT {`
`46`	`46`
`47`	`47`	`override DataFlow::Node getOptions() { none() }`
`48`	`48`
`49`		`- override predicate verifiesSignature() { exists(verifyCall()) }`
	`49`	`+ override predicate verifiesSignature() { exists(this.verifyCall()) }`
`50`	`50`	`}`
`51`	`51`	`}`