simplify regexp

erik-krogh · esbena · web-flow · commit 0372ccce02f3 · 2021-10-27T20:04:24.000+02:00
Co-authored-by: Esben Sparre Andreasen &lt;esbena@github.com&gt;
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/CookieLibraries.qll b/javascript/ql/lib/semmle/javascript/frameworks/CookieLibraries.qll
@@ -80,7 +80,7 @@ private predicate canHaveSensitiveCookie(DataFlow::Node node) {
  */
 bindingset[s]
 private string getCookieName(string s) {
-  result = s.regexpCapture("\\s*\\b([^=\\s]*)\\b\\s*=.*", 1)
+  result = s.regexpCapture("([^=]*)=.*", 1).trim()
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ private predicate canHaveSensitiveCookie(DataFlow::Node node) {`
`80`	`80`	`*/`
`81`	`81`	`bindingset[s]`
`82`	`82`	`private string getCookieName(string s) {`
`83`		`- result = s.regexpCapture("\\s\\b([^=\\s])\\b\\s=.", 1)`
	`83`	`+ result = s.regexpCapture("([^=])=.", 1).trim()`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`/**`