Model newly added functions

Author: owen-mc

go/ql/lib/ext/builtin.model.yml

@@ -11,3 +11,4 @@ extensions:
       - ["", "", False, "copy", "", "", "Argument[1].ArrayElement", "Argument[0].ArrayElement", "value", "manual"]
       - ["", "", False, "max", "", "", "Argument[0..1000]", "ReturnValue", "value", "manual"]
       - ["", "", False, "min", "", "", "Argument[0..1000]", "ReturnValue", "value", "manual"]
+      - ["", "", False, "new", "", "", "Argument[0]", "ReturnValue.Dereference", "value", "manual"]

go/ql/lib/ext/bytes.model.yml

@@ -43,6 +43,7 @@ extensions:
       - ["bytes", "", False, "TrimSuffix", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
       - ["bytes", "Buffer", True, "Bytes", "", "", "Argument[receiver]", "ReturnValue", "taint", "manual"]
       - ["bytes", "Buffer", True, "Next", "", "", "Argument[receiver]", "ReturnValue", "taint", "manual"]
+      - ["bytes", "Buffer", True, "Peek", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"]
       - ["bytes", "Buffer", True, "ReadBytes", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"]
       - ["bytes", "Buffer", True, "ReadString", "", "", "Argument[receiver]", "ReturnValue[0]", "taint", "manual"]
       - ["bytes", "Reader", True, "Reset", "", "", "Argument[0]", "Argument[receiver]", "taint", "manual"]

go/ql/lib/ext/errors.model.yml

@@ -4,5 +4,6 @@ extensions:
       extensible: summaryModel
     data:
       - ["errors", "", False, "As", "", "", "Argument[0]", "Argument[1]", "taint", "manual"]
+      - ["errors", "", False, "AsType", "", "", "Argument[0]", "ReturnValue[0]", "taint", "manual"]
       - ["errors", "", False, "New", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]
       - ["errors", "", False, "Unwrap", "", "", "Argument[0]", "ReturnValue", "taint", "manual"]

go/ql/test/library-tests/semmle/go/dataflow/ExternalTaintFlow/completetest.expected

@@ -1,4 +1,2 @@
 invalidModelRow
 testFailures
-| test.go:204:21:204:51 | comment | Missing result: hasTaintFlow="call to new" |
-| test.go:205:21:205:55 | comment | Missing result: hasTaintFlow="star expression" |

go/ql/test/library-tests/semmle/go/dataflow/ExternalValueFlow/completetest.expected

@@ -1,3 +1,2 @@
 invalidModelRow
 testFailures
-| test.go:213:21:213:55 | comment | Missing result: hasValueFlow="star expression" |

go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/StdlibTaintFlow.expected

@@ -1,3 +0,0 @@
-| Builtin.go:112:13:112:24 | call to newSource | No flow to its sink |
-| Bytes.go:635:13:635:25 | call to newSource | No flow to its sink |
-| Errors.go:72:13:72:24 | call to newSource | No flow to its sink |