C++: Autoformat.

geoffw0 · geoffw0 · commit 0534c69c767c · 2020-08-06T19:11:46.000+01:00
diff --git a/cpp/ql/src/Likely Bugs/Likely Typos/inconsistentLoopDirection.ql b/cpp/ql/src/Likely Bugs/Likely Typos/inconsistentLoopDirection.ql
@@ -50,12 +50,11 @@ predicate illDefinedDecrForStmt(
     DataFlow::localFlowStep(DataFlow::exprNode(initialCondition), DataFlow::exprNode(lesserOperand)) and
     // `initialCondition` < `terminalCondition`
     (
+      upperBound(initialCondition) < lowerBound(terminalCondition) and
       (
-        upperBound(initialCondition) < lowerBound(terminalCondition) and (
-          // exclude cases where the loop counter is `unsigned` (where wrapping behaviour can be used deliberately)
-          v.getUnspecifiedType().(IntegralType).isSigned() or
-          initialCondition.getValue().toInt() = 0
-        )
+        // exclude cases where the loop counter is `unsigned` (where wrapping behaviour can be used deliberately)
+        v.getUnspecifiedType().(IntegralType).isSigned() or
+        initialCondition.getValue().toInt() = 0
       )
       or
       (forstmt.conditionAlwaysFalse() or forstmt.conditionAlwaysTrue())

Original file line number	Diff line number	Diff line change
`@@ -50,12 +50,11 @@ predicate illDefinedDecrForStmt(`
`50`	`50`	`DataFlow::localFlowStep(DataFlow::exprNode(initialCondition), DataFlow::exprNode(lesserOperand)) and`
`51`	`51`	// `initialCondition` < `terminalCondition`
`52`	`52`	`(`
	`53`	`+ upperBound(initialCondition) < lowerBound(terminalCondition) and`
`53`	`54`	`(`
`54`		`- upperBound(initialCondition) < lowerBound(terminalCondition) and (`
`55`		- // exclude cases where the loop counter is `unsigned` (where wrapping behaviour can be used deliberately)
`56`		`- v.getUnspecifiedType().(IntegralType).isSigned() or`
`57`		`- initialCondition.getValue().toInt() = 0`
`58`		`- )`
	`55`	+ // exclude cases where the loop counter is `unsigned` (where wrapping behaviour can be used deliberately)
	`56`	`+ v.getUnspecifiedType().(IntegralType).isSigned() or`
	`57`	`+ initialCondition.getValue().toInt() = 0`
`59`	`58`	`)`
`60`	`59`	`or`
`61`	`60`	`(forstmt.conditionAlwaysFalse() or forstmt.conditionAlwaysTrue())`